Closed
Bug 2008877
Opened 6 months ago
Closed 1 month ago
Rename --color-gray-05 to --color-gray-0
Categories
(Toolkit :: Themes, task, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: jules, Assigned: phonekhantkyawswa555, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [recomp])
Attachments
(1 file, 1 obsolete file)
Gray scale inherits the old naming model starting at 05. Let's make sure it starts with 0 instead, like our new scales (example). We then need to replace everywhere using it for the new name.
Since I marked this as a good first bug, here is some guidance too on how to build tokens
Updated•6 months ago
|
| Assignee | ||
Comment 1•6 months ago
|
||
Hello, I would like to work on this issue. Could this bug be assigned to me?
Updated•6 months ago
|
Assignee: nobody → phonekhantkyawswa555
Mentor: fterdal
| Assignee | ||
Comment 2•6 months ago
|
||
| Assignee | ||
Comment 3•6 months ago
|
||
Updated•6 months ago
|
Attachment #9538965 -
Attachment description: Bug 2008877 - Renamed --color-gray-05 to --color-gray-0 by editing design-tokens.json and replaced references to the old name with the new one in other files r=fterdal → Bug 2008877 - Rename --color-gray-05 to --color-gray-0 r=Standard8
Updated•6 months ago
|
Attachment #9538966 -
Attachment is obsolete: true
Updated•5 months ago
|
Attachment #9538965 -
Attachment description: Bug 2008877 - Rename --color-gray-05 to --color-gray-0 r=Standard8 → Bug 2008877 - Rename --color-gray-05 to --color-gray-0
Comment 4•2 months ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
Assignee: phonekhantkyawswa555 → nobody
Updated•2 months ago
|
Assignee: nobody → phonekhantkyawswa555
Status: NEW → ASSIGNED
Comment 5•2 months ago
|
||
Reassigning to Phone, since he said he'd like to pick this back up again.
Pushed by fterdal@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/b0ac1c45e430
https://hg.mozilla.org/integration/autoland/rev/677e83bad153
Rename --color-gray-05 to --color-gray-0 r=fterdal,desktop-theme-reviewers,frontend-codestyle-reviewers,tgiles,Standard8,mconley,tabbrowser-reviewers,omc-reviewers,urlbar-reviewers,aminomancer,nsharpley,emilio
Comment 7•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in
before you can comment on or make changes to this bug.
Description
•