Open Bug 2008878 Opened 10 months ago Updated 3 months ago

Remove all unused --color-*-100 and --color-*-110 from color design token scales (except for grays)

Categories

(Toolkit :: Themes, task, P3)

task

Tracking

()

People

(Reporter: jules, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [recomp])

Attachments

(1 external file)

As the person who added our newest color scale, I have noticed we aren't using any of the 100 and 110 colors in design tokens, and they've been out for a year, so let's clean our scales up by removing them (except --color-gray-100).

Since I marked this as a good first bug, here is how to build tokens

Hi @jules, can I get on this?

Flags: needinfo?(jules)
Assignee: nobody → maryojo3
Flags: needinfo?(jules)

Let me know if you need any help Mary, I just assigned it to you :)

Okay, thank you Jules!

Hi Jules, i've made the update, but I want to clarify this - do I need to create a new branch (the guide doesn't say so) and also do I use your full name for the reviewer name on the commit?

Flags: needinfo?(jules)

Hi Mary, you don't need to create a new branch. And my user name there is "jules" so you can just add that. Thank you for asking.

Flags: needinfo?(jules)

Okay, i tried running the command to setup phabricator and i'm getting this error after I put in the token:
URLError: <urlopen error [Errno 97] Address family not supported by protocol>
Run moz-phab again with '--trace' to show debugging output

Is there something I might be missing, I asked on the community, I've not gotten a response yet

Flags: needinfo?(jules)

It works now! I just made the push

Great! Left you a comment in the patch :)

Flags: needinfo?(jules)
Pushed by mstriemer@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9ec4e84d33df https://hg.mozilla.org/integration/autoland/rev/97623ac259ce Remove unused --color-100 and --color-110 from color design token scales, except for grays. r=jules,desktop-theme-reviewers,accessibility-frontend-reviewers,morgan
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fb93bf60c661 https://hg.mozilla.org/integration/autoland/rev/aaad69833d3c Revert "Bug 2008878 - Remove unused --color-100 and --color-110 from color design token scales, except for grays. r=jules,desktop-theme-reviewers,accessibility-frontend-reviewers,morgan" for causing Node failures.

Looks like this test needs updating to pass (you'll want to check for others here affected by the removal too - looks like there's 3 in total from the failure log linked above) but here's an example: https://searchfox.org/firefox-main/rev/9a3317a65545e83f4e32b94fdf1f6860342423ef/tools/lint/stylelint/stylelint-plugin-mozilla/tests/use-design-tokens.background-color.tests.mjs#250

Okay, but i'm a bit confused here. I've seen the 3 errors but are they all linked to the same color token?

Flags: needinfo?(maryojo3)

I left a comment in the patch describing some of the things we were able to debug as the failures.
Most are related to the comment Stuart left above.
It can be a little hard to parse failures, unfortunately :(

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:maryojo3, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(maryojo3)
Flags: needinfo?(jules)

Okay

Flags: needinfo?(maryojo3)

Hey Mary, let me know if you need help picking this back up, but cleaning up the files mentioned in Phabricator here should do it

Flags: needinfo?(jules)

Hi Jules, sorry, I missed this. I'm having some issues with my pc, hopefully I can fix it soon.

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Assignee: maryojo3 → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: