Closed Bug 2008929 Opened 10 months ago Closed 10 months ago

Move Smartbar into AI Window page

Categories

(Core :: Machine Learning: Frontend, task, P1)

task
Points:
2

Tracking

()

VERIFIED FIXED
149 Branch
Tracking Status
firefox149 --- verified

People

(Reporter: flozia, Assigned: flozia)

References

(Blocks 1 open bug)

Details

(Whiteboard: [genai][input])

Attachments

(1 external file)

For the initial for of Urlbar -> Smartbar we added it to the sidebar chrome. We need to move it and make some changes to the Smartbar to make it work in-page.

Whiteboard: [genai][input]

This moves the Smartbar into the AI Window page. To support this, the SmartbarInput now falls back to getting the browser window when gBrowser is not available in the current window context.

The Smartbar currently dependents on global Urlbar and browser styles. Making it independent for in-page use will be addressed with Bug 2008938.

Attachment #9536105 - Attachment description: WIP: Bug 2008929 - Move Smartbar into AIWindow → Bug 2008929 - Move Smartbar into AIWindow
Pushed by fzia@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ffee63352796 https://hg.mozilla.org/integration/autoland/rev/9e5996508081 Move Smartbar into AIWindow r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,Mardak,Standard8,dao
Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4c02c2b0971b https://hg.mozilla.org/integration/autoland/rev/88a11abf7803 Revert "Bug 2008929, Bug 2008544, 2008542 - Move Smartbar into AIWindow r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,Mardak,Standard8,dao" for causing failures on Assertions.h

Backed out for causing failures on Assertions.h

Backout link

Push with failures

Failure log
Failure log

Flags: needinfo?(fzia)
Pushed by fzia@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fe3882d97fdc https://hg.mozilla.org/integration/autoland/rev/e4e42efc4e23 Move Smartbar into AIWindow r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,Mardak,Standard8,dao,tschuster
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/602449d3c7a3 https://hg.mozilla.org/integration/autoland/rev/55c7f96ec252 Revert "Bug 2008929, Bug 2008544, Bug 2008542 - Move Smartbar into AIWindow r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,Mardak,Standard8,dao,tschuster" for causing failures at browser_conversation_stream.js.
Depends on: 2000992
No longer depends on: 2000992
Pushed by elee@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/43117be8f2fd https://hg.mozilla.org/integration/autoland/rev/0080df0e5323 Move Smartbar into AIWindow r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,Mardak,Standard8,dao,tschuster
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
Blocks: 2011942
Regressions: 2012969
Regressions: 2013784
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49]
QA Contact: rdoghi

Verified as fixed in our latest Beta 149.0b1

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49] → [qa-triage-done-c150/b149] [qa-ver-done-c150/b49]
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-done-c150/b49] → [qa-triage-done-c150/b149] [qa-ver-done-c150/b149]
Flags: needinfo?(fzia)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: