2009004 - Navigation API: Implement #dom-navigationprecommitcontroller-addhandler

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Jan Jaeschke [:jjaschke]]

This was introduced by HTML#11984. The spec PR names bug 2004569 as implementation bug, but it only updates the WPTs and is closed already, hence this new bug.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 2009004 - Navigation API: Implement #dom-navigationprecommitcontroller-addhandler. r=farre!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e5bb7184794a
https://hg.mozilla.org/integration/autoland/rev/fc7989a20bf3
Navigation API: Implement #dom-navigationprecommitcontroller-addhandler. r=farre,webidl,smaug,saschanaz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/79eb0b7215cd
https://hg.mozilla.org/integration/autoland/rev/4852be7d35d1
Remove navigation related subtest that is passing now. a=test-only

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/974b0546f470
https://hg.mozilla.org/integration/autoland/rev/74f40e6ee9d0
Revert "Bug 2009004 - Navigation API: Implement #dom-navigationprecommitcontroller-addhandler. r=farre,webidl,smaug,saschanaz" for causing wpt failures.

Comment 5

[Serban Stanca [:SerbanS]]

Reverted this because it was causing wpt failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.+) | NavigationPrecommitController interface: operation addHandler(NavigationInterceptHandler) - assert_own_property: self does not have own property "NavigationPrecommitController" expected property "NavigationPrecommitController" missing

Comment 6

[Jan Jaeschke [:jjaschke]]

Ah, there's android + no ship of course. I updated the expectation and I'll reland.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/857e8d9114b7
https://hg.mozilla.org/integration/autoland/rev/7f1657e2c77b
Navigation API: Implement #dom-navigationprecommitcontroller-addhandler. r=farre,webidl,smaug,saschanaz

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7f1657e2c77b

Comment 9

[Donal Meehan [:dmeehan]]

:jjaschke, could you consider nominating this for a release note? (Process info)

Comment 10

[Jan Jaeschke [:jjaschke]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This allows registering a post-commit navigation handler during the pre-commit phase, to allow a multi-step navigation process.
[Affects Firefox for Android]: Yes, but only with SHIP
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://github.com/whatwg/html/issues/11956

Comment 11

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx148 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx148 release notes.

Comment 12

[Hamish Willee]

FF148 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/42780

@Donal, I could be wrong but I think you need to modify the release note to change NavigationPrecommitController to NavigationPrecommitController.addHandler() (NavigationPrecommitController was already supported from 141. The change here is that NavigationPrecommitController.addHandler() is now supported). [Just requesting info so you don't miss this]

Comment 13

[Donal Meehan [:dmeehan]]

(In reply to Hamish Willee from comment #12)

FF148 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/42780

@Donal, I could be wrong but I think you need to modify the release note to change NavigationPrecommitController to NavigationPrecommitController.addHandler() (NavigationPrecommitController was already supported from 141. The change here is that NavigationPrecommitController.addHandler() is now supported). [Just requesting info so you don't miss this]

Thanks, Hamish! I've updated the note

Comment 14

[Donal Meehan [:dmeehan]]

Added to the final Fx148 release notes