2009189 - [HDR] Crash in [@ mozilla::layers::NativeLayerWaylandRender::NotifySurfaceReady]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

45 crashes for Nightlies with version 147.0a1 and 148.0a1, relatively many reports after more than 15 minutes after launch.

Crash report: https://crash-stats.mozilla.org/report/index/9395d3c5-e0ae-463d-9f04-ff13a0260107

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(mInProgressBuffer)

Top 10 frames:

0  libxul.so  MOZ_CrashSequence(void*, long)  mfbt/Assertions.h:237
0  libxul.so  mozilla::layers::NativeLayerWaylandRender::NotifySurfaceReady()  gfx/layers/NativeLayerWayland.cpp:1197
1  libxul.so  mozilla::wr::RenderCompositorNative::UnbindNativeLayer()  gfx/webrender_bindings/RenderCompositorNative.cpp:314
2  libxul.so  webrender::renderer::Renderer::draw_frame  gfx/wr/webrender/src/renderer/mod.rs:5463
3  libxul.so  webrender::renderer::Renderer::render_impl  gfx/wr/webrender/src/renderer/mod.rs:1725
4  libxul.so  webrender::renderer::Renderer::render  gfx/wr/webrender/src/renderer/mod.rs:1412
5  libxul.so  wr_renderer_render  gfx/webrender_bindings/src/bindings.rs:652
6  libxul.so  mozilla::wr::RendererOGL::UpdateAndRender(mozilla::Maybe<mozilla::gfx::IntSiz...  gfx/webrender_bindings/RendererOGL.cpp:230
6  libxul.so  mozilla::wr::RenderThread::UpdateAndRender(mozilla::wr::WrWindowId, mozilla::...  gfx/webrender_bindings/RenderThread.cpp:849
7  libxul.so  mozilla::wr::RenderThread::HandleFrameOneDocInner(mozilla::wr::WrWindowId, mo...  gfx/webrender_bindings/RenderThread.cpp:663

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2009189 [Wayland] Don't crash on missing mInProgressBuffer at NativeLayerWaylandRender::NotifySurfaceReady() r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/657b3b5a8391
https://hg.mozilla.org/integration/autoland/rev/769b9bf9bf09
[Wayland] Don't crash on missing mInProgressBuffer at NativeLayerWaylandRender::NotifySurfaceReady() r=emilio

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/769b9bf9bf09

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox148 to wontfix.

For more information, please visit BugBot documentation.