2009222 - Avoid scrollbars in anchor-scroll-chained-003.html

Status: RESOLVED FIXED

(Core :: Layout: Positioned, enhancement)

Description

[David Shin[:dshin]]

Context: https://github.com/web-platform-tests/wpt/pull/55022#issuecomment-3499478504

Comment 1

[David Shin[:dshin]]

Attachment: Bug 2009222: Hide scrollbars in anchor-scroll-chained-003.html. r=#anchor-pos

As discussed in 1, because positioned elements intersect scrollbar gutters,
leaving scrollbars visible ends up testing the scrollbar painting order.

Comment 2

[Daniel Holbert [:dholbert]]

Given the discussion / general agreement about the issue on https://github.com/web-platform-tests/wpt/pull/55022#issuecomment-3499478504 , I don't think a test-change-proposal is necessary here.

But it's probably worth posting an FYI on that thread as a heads-up that this test-fix is incoming, to close the loop there & as a heads-up for anyone else who might've had "fix this test" on their to-do list coming out of that thread.

Comment 4

[Timothy Nikkel (:tnikkel)]

I put a patch in bug 2009316 to update/cleanup annotations after this patch (some changes not depending on this change). Not sure if you still need to update annotations to land this, I'll update my patch if you do.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c006c4d1803
https://hg.mozilla.org/integration/autoland/rev/d7b117c5f728
Hide scrollbars in anchor-scroll-chained-003.html. r=dholbert

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57104 for changes under testing/web-platform/tests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/863296ba9fd4
https://hg.mozilla.org/integration/autoland/rev/0fd696f903f4
Revert "Bug 2009222: Hide scrollbars in anchor-scroll-chained-003.html. r=dholbert" for causing Wr failures on anchor-scroll-chained-003.html

Comment 8

[Cristina Horotan [:chorotan]]

Backed out for causing Wr failures on anchor-scroll-chained-003.html

Backout link

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6b2591df29ad
https://hg.mozilla.org/integration/autoland/rev/1e2c425254e4
Hide scrollbars in anchor-scroll-chained-003.html. r=dholbert

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1e2c425254e4

Comment 11

[David Shin[:dshin]]

Attachment: Bug 2009222: Modify anchor-scroll-chained-003.html to use scrollbar-width: none, not overflow: hidden. r=#anchor-pos

As per WPT review feedback 1. No real mechanical difference, but it
communicates the intent better.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b61489155d25
https://hg.mozilla.org/integration/autoland/rev/233d41b97c03
Modify anchor-scroll-chained-003.html to use scrollbar-width: none, not overflow: hidden. r=layout-anchor-positioning-reviewers,emilio

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/233d41b97c03

Comment 14

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot