2009321 - [wpt-sync] Sync PR 57101 - Revert "Make <menuitem> automatically be an interest invoker"

Status: NEW

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 57101 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/57101
Details from upstream follow.

[e-mail] <[e-mail]> wrote:

Revert "Make <menuitem> automatically be an interest invoker"

This reverts commit 106ba087eb332736a27034e848184551d8e144e4.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5948842580115456

Sample build with failed test: https://ci.chromium.org/b/8693183460081875409
Affected test(s):
://:headless_shell_wpt!webtest::external/wpt/shadow-dom/focus-navigation/menu/tentative#focus-menu-elements.html
://:headless_shell_wpt!webtest::external/wpt/shadow-dom/focus-navigation/menu/tentative#focus-menu-elements.html

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5948842580115456&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7276492&type=BUG

Original change's description:

Make \<menuitem> automatically be an interest invoker

If a menuitem is a submenu invoker, it automatically becomes
an interest invoker, so that hovering it opens the submenu.

Fixed: 422216068
Bug: 406566432
Change-Id: I93b844dea7b4c321cdb6b148bae8654e73c90038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7276492
Auto-Submit: Mason Freed \<[e-mail]>
Commit-Queue: Mason Freed \<[e-mail]>
Reviewed-by: David Baron \<[e-mail]>
Commit-Queue: David Baron \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1566675}

Bug: 406566432
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Icf905c96ecc5443bbe0dfbdd7e3114d6ebd10e31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7415371
Reviewed-by: Dominic Battre \<[e-mail]>
Commit-Queue: Dominic Battre \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: Dominic Battre \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1566772}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 57101 applied with additional changes from upstream: f309244f1a6cc710dec7eabf700f511eb4fbb50d, bbffa1c155b0731d123ab4863eb984634002ede2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=646b9241d62ed25cece83d32b18062e4955ffce3

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL: 5

Chrome

OK : 1
PASS: 5

Safari

OK : 1
FAIL: 5

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/menu/tentative/menuitem-activate.html [wpt.fyi]
  • User menuitem activation works with the toggle-menu command: FAIL (Chrome: PASS, Safari: FAIL)
  • User menuitem activation works with show-popover command: FAIL (Chrome: PASS, Safari: FAIL)
  • Menulist inside a popover works correctly; does not get accidentally dismissed by opening submenus: FAIL (Chrome: PASS, Safari: FAIL)
  • A mousedown-drag-mouseup gesture on a normal menuitem picks the item: FAIL (Chrome: PASS, Safari: FAIL)
  • A mousedown-drag-mouseup gesture on a submenu item leaves both menus open: FAIL (Chrome: PASS, Safari: FAIL)