Closed
Bug 2009419
Opened 4 months ago
Closed 4 months ago
mach telemetry slows down `jj fix` + pipelint
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox148 fixed)
RESOLVED
FIXED
148 Branch
| Tracking | Status | |
|---|---|---|
| firefox148 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
Details |
Using jj fix with pipelint can be very slow (> 5-8 minutes for a larger patch stack). The main culprit on my machine is mach's telemetry because the pipelint script invokes mach separately for each file.
Setting the DISABLE_TELEMETRY environment variable in the pipelint script makes it much faster (~35 seconds).
| Assignee | ||
Comment 1•4 months ago
|
||
Updated•4 months ago
|
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Pushed by jdemooij@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/177a7de62579
https://hg.mozilla.org/integration/autoland/rev/1d4ba240ab20
Disable build telemetry for the pipelint script. r=ahal
Comment 3•4 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•