2009792 - Don't constrain month if monthCode is also present

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P1)

Description

[André Bargull [:anba]]

Temporal.PlainDate.from({ calendar: 'gregory', monthCode: 'M12', month: 13, year: 2019, day: 1 }, { overflow: 'constrain' }) should throw a RangeError. See https://github.com/tc39/proposal-intl-era-monthcode/pull/107#issuecomment-3720651274.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2009792 - Part 1: Switch month and monthCode cases in CalendarFieldMonth. r=#spidermonkey-reviewers!

No change in behaviour. (Except for RangeError error messages.)

This change is needed for part 2.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 2009792 - Part 2: Don't constrain month if monthCode is also present. r=#spidermonkey-reviewers!

Comment 3

[André Bargull [:anba]]

Attachment: Bug 2009792 - Part 3: Prefer Int32ToCString for int32 values. r=#spidermonkey-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4552297da3df
https://hg.mozilla.org/integration/autoland/rev/d28786e6c9f8
Part 1: Switch month and monthCode cases in CalendarFieldMonth. r=spidermonkey-reviewers,dminor
https://github.com/mozilla-firefox/firefox/commit/1ff34544012d
https://hg.mozilla.org/integration/autoland/rev/c3aa0eb9cc02
Part 2: Don't constrain month if monthCode is also present. r=spidermonkey-reviewers,dminor
https://github.com/mozilla-firefox/firefox/commit/06f08d63a74a
https://hg.mozilla.org/integration/autoland/rev/dfb19519c9fa
Part 3: Prefer Int32ToCString for int32 values. r=spidermonkey-reviewers,dminor

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d28786e6c9f8
https://hg.mozilla.org/mozilla-central/rev/c3aa0eb9cc02
https://hg.mozilla.org/mozilla-central/rev/dfb19519c9fa