[wpt-sync] Sync PR 57130 - [Masonry] Update grid-lanes-direction syntax
Categories
(Core :: Layout: Grid, task, P4)
Tracking
()
People
(Reporter: wpt-sync, Unassigned)
References
(Depends on 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 57130 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/57130
Details from upstream follow.
Alison Maher <almaher@microsoft.com> wrote:
[Masonry] Update grid-lanes-direction syntax
Update the syntax of 'grid-lanes-direction' to match the proposal for
option A in the related CSSWG issue [1]:'grid-lanes-direction: normal | [ row | column ] [ fill-reverse
|| track-reverse ]?'The CSSWG issue is still being discussed, so the syntax and property
used for the direction may be subject to more changes in the future.All tests have been updated. We don't yet support 'fill-reverse', but
the implementation for this will be added in follow up changes.[1] https://github.com/w3c/csswg-drafts/issues/12803#issuecomment-3643945412
Bug: 343257585
Change-Id: I02ef728047dbea54610c7e3eae9d7a600f41f39c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7425336
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1567952}
| Assignee | ||
Updated•2 days ago
|
| Assignee | ||
Comment 1•2 days ago
|
||
| Assignee | ||
Comment 2•2 days ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 27 tests and 33 subtests
Status Summary
Firefox
OK : 7
PASS: 31
FAIL: 89
Chrome
OK : 7
PASS: 44
FAIL: 76
Safari
OK : 7
PASS: 32
FAIL: 88
Links
Details
New Tests That Don't Pass
- /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-003.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-multi-span-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-multi-span-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-multi-span-003.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-multi-span-004.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-multi-span-005.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-multi-span-006.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-003.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:PASS) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-multi-span-001.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-multi-span-002.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-multi-span-003.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-multi-span-004.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-multi-span-005.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL) - /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-direction-computed.html [wpt.fyi]
- Property grid-lanes-direction value 'row':
FAIL(Chrome:PASS, Safari:FAIL) - Property grid-lanes-direction value 'column':
FAIL(Chrome:PASS, Safari:FAIL) - Property grid-lanes-direction value 'row track-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'row fill-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'row track-reverse fill-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'row fill-reverse track-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'column track-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'column fill-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'column track-reverse fill-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'column fill-reverse track-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes-direction value 'normal':
FAIL(Chrome:FAIL, Safari:FAIL)
- Property grid-lanes-direction value 'row':
- /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-direction-valid.html [wpt.fyi]
- e.style['grid-lanes-direction'] = "row" should set the property value:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes-direction'] = "row track-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "row fill-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "row track-reverse fill-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "row fill-reverse track-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "column" should set the property value:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes-direction'] = "column track-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "column fill-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "column track-reverse fill-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "column fill-reverse track-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes-direction'] = "normal" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL)
- e.style['grid-lanes-direction'] = "row" should set the property value:
- /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-shorthand-computed.html [wpt.fyi]
- Property grid-lanes value '"a b" 1fr 2fr row':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes value '8px column':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes value '8px column track-reverse fill-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes value '"a b c" 10% 20% 30% row track-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes value '"a b" 10px 20px column fill-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes value 'min-content row fill-reverse track-reverse':
FAIL(Chrome:FAIL, Safari:FAIL) - Property grid-lanes value 'repeat(5, auto)':
FAIL(Chrome:FAIL, Safari:FAIL)
- Property grid-lanes value '"a b" 1fr 2fr row':
- /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-shorthand-serialization.html [wpt.fyi]
- grid-template-rows: none,
grid-template-columns: none,
grid-template-areas: none,
grid-lanes-direction: column should be valid.:FAIL(Chrome:FAIL, Safari:FAIL) - grid-template-rows: 10px,
grid-template-columns: none,
grid-template-areas: none,
grid-lanes-direction: column should be valid.:FAIL(Chrome:FAIL, Safari:FAIL) - grid-template-rows: 10px 20px,
grid-template-columns: 10% 20%,
grid-template-areas: none,
grid-lanes-direction: row should be valid.:FAIL(Chrome:FAIL, Safari:FAIL) - grid-template-rows: none,
grid-template-columns: 1fr 1fr 3fr,
grid-template-areas: "a a b",
grid-lanes-direction: column should be valid.:FAIL(Chrome:FAIL, Safari:FAIL) - grid-template-rows: 20% 40%,
grid-template-columns: none,
grid-template-areas: "b" "a",
grid-lanes-direction: row should be valid.:FAIL(Chrome:FAIL, Safari:FAIL) - grid-template-rows: none,
grid-template-columns: fit-content(calc(0.5em + 10px)),
grid-template-areas: none,
grid-lanes-direction: column track-reverse fill-reverse should be valid.:FAIL(Chrome:FAIL, Safari:FAIL) - grid-template-rows: 10% 20% 40%,
grid-template-columns: none,
grid-template-areas: "a" "b" "c",
grid-lanes-direction: row fill-reverse track-reverse should be valid.:FAIL(Chrome:FAIL, Safari:FAIL)
- grid-template-rows: none,
- /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-shorthand-valid.html [wpt.fyi]
- grid-lanes followed by !important:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = ""a" calc(10px) column fill-reverse" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "minmax(calc(30% + 40vw), 10px)" should set the property value:
FAIL(Chrome:FAIL, Safari:FAIL) - grid-lanes: minmax(10px, 20px) row should be valid.:
FAIL(Chrome:FAIL, Safari:FAIL) - grid-lanes: 1px 2px should be valid.:
FAIL(Chrome:FAIL, Safari:FAIL) - grid-lanes: "a" 10px should be valid.:
FAIL(Chrome:FAIL, Safari:FAIL) - grid-lanes: "a b" 10px 20px row should be valid.:
FAIL(Chrome:FAIL, Safari:FAIL) - grid-lanes: "a b c" 10% 20% 30% row track-reverse should be valid.:
FAIL(Chrome:FAIL, Safari:FAIL) - grid-lanes: repeat(5, auto) row should be valid.:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "none" should set grid-lanes-direction:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "none" should set grid-template-areas:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = "none" should set grid-template-columns:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = "none" should not set unrelated longhands:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "10px" should set grid-lanes-direction:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "10px" should set grid-template-areas:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = "10px" should set grid-template-columns:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = "10px" should not set unrelated longhands:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% column" should set grid-lanes-direction:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% column" should set grid-template-areas:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% column" should set grid-template-columns:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% column" should not set unrelated longhands:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = ""b b a" 1fr 2fr 3fr row" should set grid-lanes-direction:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b b a" 1fr 2fr 3fr row" should set grid-template-areas:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b b a" 1fr 2fr 3fr row" should set grid-template-rows:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b b a" 1fr 2fr 3fr row" should not set unrelated longhands:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "repeat(2, auto) row track-reverse fill-reverse" should set grid-lanes-direction:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "repeat(2, auto) row track-reverse fill-reverse" should set grid-template-areas:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "repeat(2, auto) row track-reverse fill-reverse" should set grid-template-rows:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = "repeat(2, auto) row track-reverse fill-reverse" should not set unrelated longhands:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% normal" should set grid-lanes-direction:
FAIL(Chrome:FAIL, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% normal" should set grid-template-areas:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% normal" should set grid-template-columns:
FAIL(Chrome:PASS, Safari:FAIL) - e.style['grid-lanes'] = ""b a" 20% 40% normal" should not set unrelated longhands:
FAIL(Chrome:FAIL, Safari:FAIL)
- grid-lanes followed by !important:
Description
•