2009917 - In the about:opentabs page the containers icons have no padding on the right side while hovered

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Split View, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 149.0a1 (2026-01-12)

Affected versions

• 149.0a1 (2025-01-12)

Tested platforms

• Affected platforms: Ubuntu 24, Windows 11, macOS 14
• Unaffected platforms: none

Steps to reproduce

1. Add some tabs to a random container.
2. Use the Add Split View context menu option.
3. Inside about:opentabs hover over a tab that belongs to a container.

Expected result

• The container icon is correctly positioned inside the hover area.

Actual result

• The containers icons have no padding on the right side while hovered

Regression range

• Not a regression.

Additional notes

• Attached a screenshot.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Firefox Contributors' Quick Reference,
     which has answers to most development questions.
3. Start working on this bug.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #sidebar channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test browser/components/tabbrowser/test/browser.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • Getting your code reviewed
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 2

[Pranjali Srivastava]

I would like to work on this if available

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Thanks Pranjali! You may work on this bug.

Comment 4

[Noble Chinonso]

Hi I will be happy to work on this

Comment 5

[konyhéa]

Attachment: Before and after screenshots showing the container icon padding fix — icons now have proper inline-end spacing within the hover area.

Comment 6

[Pranjali Srivastava]

I was assigned to work on this bug and I'm working on it.
Thanks everyone

Comment 7

[konyhéa]

Hi :nikkis, I'd like to volunteer to work on this bug.

I have reviewed the issue and noticed the container icon had inconsistent padding that caused misalignment within the hover area. I fixed this by applying margin-inline-end: 4px to .fxview-tab-row-container-indicator instead of padding, as margin adds spacing outside the element without
distorting the background image.

Patch submitted for review on Phabricator: https://phabricator.services.mozilla.com/D289089

Please see attached before/after screenshots for
visual comparison.

Comment 8

[konyhéa]

(In reply to Pranjali Srivastava from comment #6)

I was assigned to work on this bug, and I'm working on it.
Thanks everyone

Sorry about that, Pranjali—I didn’t notice this was already assigned.

I’ve already worked on a patch and submitted it for review. If it helps, you’re welcome to build on it or reuse anything from it. Otherwise, I’m happy to step back.

Thanks!

Comment 9

[konyhéa]

Attachment: Bug 2009917 - add margin-inline-end to fxview-tab-row-container-indicator for proper alignment on hover

Comment 10

[Pranjali Srivastava]

Attachment: Bug 2009917 - Add inline margin to fxview tab row container indicator

For bug 2009917. Fix spacing issue in fxview tab row

Comment 11

[konyhéa]

Attachment: Bug 2009917 - remove unnecessary comment in fxview-tab-row-container

Comment 12

[Kelly Cochrane [:kcochrane]]

:konyhéa, Pranjali already requested to work on this one. Sorry I missed that this morning when reviewing your patch. Can you please abandon any revisions you've created for this?

Comment 13

[konyhéa]

:kcochrane
Thanks for letting me know!

I’ll go ahead and abandon the revisions I created for this bug. I appreciate the clarification and look forward to contributing to other tasks.

Thanks again!

Comment 14

[Pranjali Srivastava]

Attachment: Bug 2009917 - Add inline margin to fxview tab row container indicator

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/70834c5ca836
https://hg.mozilla.org/integration/autoland/rev/830c8bf7d5b9
Add inline margin to fxview tab row container indicator r=desktop-theme-reviewers,kcochrane

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/830c8bf7d5b9

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pranjalisrvgkp, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.