2010003 - Perma browser/extensions/webcompat/tests/browser/browser_smartblockembeds.js | browser/extensions/webcompat/tests/browser/browser_smartblockembeds.js | test_smartblock_embed_replaced - A promise chain failed when Gecko 148 merges to beta on 2026-02-23

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[agoloman]

Central-as-beta-simulation
 
How to run these simulations
 
Failure log

Comment 1

[Dale Harvey (:daleharvey)]

This is a confusing one, its causing a failure while trustpanel is disabled and the code thats being called is behind an early return that checks if the feature is enabled. Not sure at what point in the test run that test preferences are set but should have it figured out for tomorrow

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 2010003 - Dont update trustpanel if not initialised. r=daisuke

Comment 3

[pstanciu]

There are still failures as it can be seen here

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20f2ab3ef39e
https://hg.mozilla.org/integration/autoland/rev/1a6c2ea16f5d
Dont update trustpanel if not initialised. r=daisuke

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/1a6c2ea16f5d

Comment 6

[agoloman]

The patch is not working.. The failure line changed:
browser/extensions/webcompat/tests/browser/browser_smartblockembeds.js | test_smartblock_embed_replaced - A promise chain failed to handle a rejection: can't access property "scheme", uri is null - stack: formatURIForDisplay@resource://gre/modules/BrowserUtils.sys.mjs

Comment 7

[Dale Harvey (:daleharvey)]

Attachment: Bug 2010003 - Ignore events while trustpanel is disabled. r=daisuke

Comment 8

[Dale Harvey (:daleharvey)]

Ugh, theres another entry point they can hit when disabled, new patch up.

Comment 9

[Cosmin Sabou [:CosminS]]

This is actually affecting 148 and was present in the last simulation of the cycle before the merge to beta. Beta link here and an uplift of the fix would be welcome.

Comment 10

[Intermittent Failures Robot]

5 failures were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 4
• try: 1

Table

	msix	no_variant	swr
linux2404-x86_64/debug			2
linux2404-x86_64/tsan			1
windows11-x86/debug		1
windows11-x86_64/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=2010003&startday=2026-01-12&endday=2026-01-18&tree=all

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b0694b5c8a2
https://hg.mozilla.org/integration/autoland/rev/4602f1c15888
Ignore events while trustpanel is disabled. r=daisuke

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4602f1c15888

Comment 13

[Donal Meehan [:dmeehan]]

:daleharvey, please add beta uplift requests when you have a moment.
As mentioned in Comment 9, Fx148 is affected since the regressor landed during Fx148 nightly.

Comment 14

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: This leaves functionality that was disabled in release to still run, there shouldnt be any user impact but it does break release tests
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Mostly test only fix
• String changes made/needed: None
• Is Android affected?: yes

Comment 15

[Dale Harvey (:daleharvey)]

Attachment: Bug 2010003 - Ignore events while trustpanel is disabled.

Original Revision: https://phabricator.services.mozilla.com/D279477

Comment 16

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This leaves functionality that was disabled in release to still run, there shouldnt be any user impact but it does break release tests
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Mostly test only fix
• String changes made/needed: N/A
• Is Android affected?: no

Comment 17

[Dale Harvey (:daleharvey)]

Attachment: Bug 2010003 - Dont update trustpanel if not initialised.

Original Revision: https://phabricator.services.mozilla.com/D279078

Comment 18

[Dale Harvey (:daleharvey)]

Comment on attachment 9538612 [details]
Bug 2010003 - Ignore events while trustpanel is disabled.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency:
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: Yes

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e10b72a58bd6
https://hg.mozilla.org/releases/mozilla-beta/rev/d083608aede1
https://github.com/mozilla-firefox/firefox/commit/1aad223e4951
https://hg.mozilla.org/releases/mozilla-beta/rev/8a1664d648a9