2010059 - Resolve memory leaks in TabbedBrowsingTest#verifyCloseAllPrivateTabsNotificationTest

Status: NEW

(Firefox for Android :: Toolbar, defect)

Description

[Moyin [:moyin]]

Affected tests

1. TabbedBrowsingTest.verifyCloseAllPrivateTabsNotificationTest

Steps to reproduce

1. Remove @SkipLeaks annotation from the affected tests
2. Run the tests, to see the leak happen

Leak signatures:

Leak trace:

Comment 1

[Moyin [:moyin]]

Attachment: Bug 2010059 - Part 1: Include API 35+ in NotificationRobot

Comment 2

[Moyin [:moyin]]

Attachment: Bug 2010059 - Part 2: Remove @SkipLeaks from TabbedBrowsingTest#verifyCloseAllPrivateTabsNotificationTest

Comment 3

[Moyin [:moyin]]

Attachment: Bug 2010059 - Part 3: Wrap fragment, navController, and toolbarStore in WeakReference

Comment 4

[Moyin [:moyin]]

Attachment: Bug 2010059 - Part 4: Update useCases to use decoupled data from the Store

Comment 5

[Moyin [:moyin]]

Attachment: Bug 2010059 - Part 5: Replace DefaultSuggestion*Provider Contexts with WeakReferences

Comment 6

[Moyin [:moyin]]

Attachment: Bug 2010059 - Part 6: Add a clear method to the BrowsingModeManager

Comment 7

[Moyin [:moyin]]

This document contains all the findings from the investigation for this ticket https://docs.google.com/document/d/1-_YcQkuZxJOxdxjmeUCxL7LzD0Ifu9lDsJcvcATFIig/edit?tab=t.0