2010195 - clarify the previously submitted uplift assessment form can be re-used after manual merge conflict resolution

Status: RESOLVED FIXED

(Conduit :: General, defect, P3)

Description

[Tooru Fujisawa [:arai]]

Steps:

1. Click "Request Uplift" from Lando
2. Fill the request form
3. Click "Create uplift request"
4. The rebase fails
5. Receive the email for the failure

Actual result:
The request form text gets lost and there's no (obvious) way to retrieve it when re-requesting after manual rebase.

Expected result:
The request form text is available somewhere.

Comment 1

[Connor Sheehan [:sheehan]]

The request form text is saved to Lando. You can re-use it after resolving merge conflicts using the Link Existing Assessment button on the Lando view of the uplift revision.

We can make this explicit in the failure email and elsewhere with some text that explicitly calls out the ability to re-use the form response you previously submitted.

Comment 2

[Tooru Fujisawa [:arai]]

Thank you for the detailed explanation.

Yeah, I didn't realize there's a button to reuse the previous request form.

To be honest, I've never thought that what I fill in the uplift request form is called as "assessment", so maybe we could either:

• Rename the button label to make it clearer it's about what you've filled in the request form
• Add a header to the request form (the form shown after you click "Request Uplift") to clarify it's an "assessment"

Also, the "Link" word is not obvious what it means.
After I understand how the data is stored, I see what operation it refers, but from the usual (successful) uplift workflow, the data structure is opaque to users.
Maybe "Reuse" or similar word could be easier to understand.
(So, maybe, "Reuse previously submitted uplift request" ?)

Comment 3

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] uplift: clarify assessment form responses can be re-used (Bug 2010195) (#862)

Comment 4

[BMO Github Automation]

Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/lando/commit/9e4df25369be83d430fe5355d030e2ee9116b223
[main] uplift: clarify assessment form responses can be re-used (Bug 2010195) r=zeid