2010236 - Prepare for expanded platform coverage of announcement events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie] (away returning 14 Apr)]

Currently, announcement events are only implemented on Android. In addition, for vestigial reasons related to the pre-CtW architecture, even the core cross-platform support for these events isn't built on Windows. We need to support announcement events on more platforms for ariaNotify. This bug will clean up and prepare for that additional platform support, but the specific support for each platform will be handled in separate bugs.

Comment 1

[James Teh [:Jamie] (away returning 14 Apr)]

Attachment: Bug 2010236 part 1: Move announcement event browser test out of the e10s directory and into events. r?eeejay

Everything is e10s now and there's an obvious, intuitive place for this to move, so let's move it.

Comment 2

[James Teh [:Jamie] (away returning 14 Apr)]

Attachment: Bug 2010236 part 2: Remove RemoteAccessible::Announce.

Announcements should always be initiated from the content process.
There's no reason for them to be initiated from the parent process directly on a RemoteAccessible.
Previously, this was only used for testing purposes.
Instead, we can have the test execute the announce call in the content process.
This also allows us to use the same browser test for both LocalAccessible and RemoteAccessible.
In turn, that means we no longer need the (local-only) mochitest.

Comment 3

[James Teh [:Jamie] (away returning 14 Apr)]

Attachment: Bug 2010236 part 3: Enable cross-platform announcement event code for Windows.

Previously, for vestigial reasons related to the pre-CtW architecture, the core cross-platform support for announcement events wasn't built on Windows.
This is no longer relevant and we need to support them on Windows soon.
This allows us to enable the cross-platform announcement event tests on Windows.

Comment 4

[James Teh [:Jamie] (away returning 14 Apr)]

Attachment: Bug 2010236 part 4: Stub PlatformAnnouncementEvent on non-Android platforms. r?eeejay

There is only a platform specific implementation of announcement events for Android.
As such, previously, PlatformAnnouncementEvent was only built for Android via ifdefs.
We will soon support this on several other platforms.
Therefore, remove the ifdefs and add empty stubs for other platforms.

Comment 5

[James Teh [:Jamie] (away returning 14 Apr)]

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=173030

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3ef59b281dd8
https://hg.mozilla.org/integration/autoland/rev/0c408c8b2fa5
part 1: Move announcement event browser test out of the e10s directory and into events. r=eeejay
https://github.com/mozilla-firefox/firefox/commit/f1bcbd80440e
https://hg.mozilla.org/integration/autoland/rev/5f781467b415
part 2: Remove RemoteAccessible::Announce. r=eeejay
https://github.com/mozilla-firefox/firefox/commit/f4f01a658855
https://hg.mozilla.org/integration/autoland/rev/60daef1ce50a
part 3: Enable cross-platform announcement event code for Windows. r=eeejay
https://github.com/mozilla-firefox/firefox/commit/35711748210a
https://hg.mozilla.org/integration/autoland/rev/aa0c0389cc15
part 4: Stub PlatformAnnouncementEvent on non-Android platforms. r=eeejay

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0c408c8b2fa5
https://hg.mozilla.org/mozilla-central/rev/5f781467b415
https://hg.mozilla.org/mozilla-central/rev/60daef1ce50a
https://hg.mozilla.org/mozilla-central/rev/aa0c0389cc15