2010258 - moz-phab patch should be explicit about which patch failed to apply

Status: NEW

(Conduit :: moz-phab, defect)

Description

[Mark Banner (:standard8)]

moz-phab version (from moz-phab version): MozPhab 2.8.1 (Python 3.13.11, Darwin)

We had been running moz-phab patch D277329 and had been getting confused at this output:

...
[phab-D277329 7ac6fe397afd] Bug 2000685 - Fix various tests after moving SearchService to be a singleton. r?mcheang!
 Date: Wed Jan 14 09:56:17 2026 +0000
 8 files changed, 42 insertions(+), 35 deletions(-)
D272915 applied
error: patch failed: browser/components/search/SearchUIUtils.sys.mjs:38
error: browser/components/search/SearchUIUtils.sys.mjs: patch does not apply
error: patch failed: browser/components/preferences/search.js:607
error: browser/components/preferences/search.js: patch does not apply
CommandError: command 'git' failed to complete successfully
Run moz-phab again with '--trace' to show debugging output

Although it said D272915 applied we initially read it as D272915 was causing the problem. Given that phab can apply parent and child revisions, which might not be the one you've mentioned in the command, it would be useful if it could be explicit and output the id and summary of the patch which failed to apply.