2010335 - Ensure Firefox icon is aligned on Windows

Status: RESOLVED FIXED

(Firefox :: Translations, task, P2)

Description

[Erik Nordin [:nordzilla]]

Attachment: image.png

Description

The Firefox icon on the about:translations page is neatly aligned with the text for the default English locale.

The icon does not appear to be nicely centered in the Italian locale.

We should ensure that the icon looks neatly centered for all locales.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: image.png

I tried this myself, and I was unable to reproduce.

Comment 2

[Erik Nordin [:nordzilla]]

I'm removing the priority from this so that it no longer blocks release.

:marco, we can definitely try to revisit this before release if you are able to reproduce after more of the remaining patches land.

Comment 3

[Erik Nordin [:nordzilla]]

Hmm, I just opened the about:translations page on my personal Windows 11 PC, and noticed that the icon is misaligned, even in English, on Windows.

I think this is a Windows vs. Unix issue (for whatever reason), rather than a locale-specific issue.

I've tested on my Linux and macOS dev machines and the icon looks fine in every locale I've tried.

I'm updating the bug title accordingly.

Comment 4

[Erik Nordin [:nordzilla]]

Moving this to P2 since we really should ensure that this looks correct on Windows, given that the majority of Firefox users are on Windows.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Bug 2010335 - Correctly align Firefox icon on about:translations r=#translations-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e6414c51274a
https://hg.mozilla.org/integration/autoland/rev/c9d4c1b1557d
Correctly align Firefox icon on about:translations r=translations-reviewers,nordzilla

Comment 7

[rperta]

https://hg.mozilla.org/mozilla-central/rev/c9d4c1b1557d