Closed Bug 2010728 Opened 3 months ago Closed 1 month ago

"New AI Window" and "New Classic Window" items shown in macOS File menu when no Firefox windows are open

Categories

(Firefox :: Menus, defect, P1)

Firefox 147
defect

Tracking

()

VERIFIED FIXED
150 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox148 --- verified
firefox149 --- verified
firefox150 --- verified

People

(Reporter: scott, Assigned: jlewis)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [genai][switcher])

Attachments

(5 files)

When Firefox is running but doesn't have any open windows (in macOS), a couple of options appear in the "File" menu which I assume should not be shown to users running the Release version?

  • "New AI Window"
  • "New Classic Window"

Firefox 147.0, macOS 26.2.

Blocks: 1992301
Keywords: regression
Regressed by: 2000985

:jlewis, since you are the author of the regressor, bug 2000985, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(jlewis)
Assignee: nobody → jlewis
Status: NEW → ASSIGNED
Flags: needinfo?(jlewis)
Severity: -- → S2
Attachment #9547648 - Attachment description: Bug 2010728 - 'New AI Window' and 'New Classic Window' items shown in macOS File menu when no Firefox windows are open → WIP: Bug 2010728 - 'New AI Window' and 'New Classic Window' items shown in macOS File menu when no Firefox windows are open
Whiteboard: [genai]
Attachment #9547648 - Attachment description: WIP: Bug 2010728 - 'New AI Window' and 'New Classic Window' items shown in macOS File menu when no Firefox windows are open → Bug 2010728 - 'New AI Window' and 'New Classic Window' items shown in macOS File menu when no Firefox windows are open
Pushed by jlewis@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a677d0b93275 https://hg.mozilla.org/integration/autoland/rev/5eab6997731f 'New AI Window' and 'New Classic Window' items shown in macOS File menu when no Firefox windows are open r=ai-frontend-reviewers,echa
Priority: -- → P1
Whiteboard: [genai] → [genai][switcher]
Flags: qe-verify+

firefox-beta Uplift Approval Request

  • User impact if declined: Incorrect menu items shown in macOS 'File' menu (ie Smart Window-specific buttons even if AI prefs disabled) with incorrect functionality as well.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: (Using macOS)
  1. Open Firefox with 'browser.aiwindow.enabled' pref FALSE
  2. Close all windows
  3. Open Firefox 'File' menu and see incorrect menu items (New Classic Window, New AI Window)
  • Risk associated with taking this patch: low
  • Explanation of risk level: Fairly low risk as fix addresses silent failure - primary addition is a null check with only few lines changed in total.
  • String changes made/needed: No
  • Is Android affected?: no
Attachment #9548066 - Flags: approval-mozilla-beta?

When no windows open:

  • Smart Window //File menu// items should not appear if **!**browser.smartwindow.enabled

Original Revision: https://phabricator.services.mozilla.com/D284723

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch

dmeehan, this bug appears even when aiwindow pref is not enabled

Thanks :Mardak for the correction.
:jlewis, could you also add a release uplift request? We could include it in the planned dot release for Fx148.

Flags: needinfo?(jlewis)

When no windows open:

  • Smart Window //File menu// items should not appear if **!**browser.smartwindow.enabled

Original Revision: https://phabricator.services.mozilla.com/D284723

Attachment #9548239 - Flags: approval-mozilla-release?

firefox-release Uplift Approval Request

  • User impact if declined: Incorrect menu items shown in macOS 'File' menu (ie Smart Window-specific buttons even if AI prefs disabled) with incorrect functionality as well. Confusing UX + want to keep AI features out of non-AI context.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: 1. Open Firefox with 'browser.aiwindow.enabled' pref FALSE
  1. Close all windows

  2. Open Firefox 'File' menu and see incorrect menu items (New Classic Window, New AI Window)

  • Risk associated with taking this patch: low
  • Explanation of risk level: Fairly low risk as fix addresses silent failure - primary addition is a null check with only few lines changed in total.
  • String changes made/needed: No
  • Is Android affected?: no

firefox-release Uplift Approval Request

  • User impact if declined: Incorrect menu items shown in macOS 'File' menu (ie Smart Window-specific buttons even if AI prefs disabled) with incorrect functionality as well. Confusing UX + want to keep AI features out of non-AI context.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: 1. Open Firefox with 'browser.aiwindow.enabled' pref FALSE
  1. Close all windows

  2. Open Firefox 'File' menu and see incorrect menu items (New Classic Window, New AI Window)

  • Risk associated with taking this patch: low
  • Explanation of risk level: Fairly low risk as fix addresses silent failure - primary addition is a null check with only few lines changed in total.

Larger fix verified in Nightly - cherry-picked fix for release uses simplified version (condition check for function + test).

  • String changes made/needed: No
  • Is Android affected?: no
Flags: needinfo?(jlewis)
QA Whiteboard: [uplift][qa-ver-needed-c150/b149]
Attachment #9548066 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I reproduced this issue using an affected Nightly 149.0a1 (2026-01-15) under macOS 26.

The issue is verified as fixed on latest Beta 149.0b2 and Nightly 150.0a1 under macOS 26.

QA Whiteboard: [uplift][qa-ver-needed-c150/b149] → [uplift][qa-ver-done-c150/b149]
Flags: qe-verify+
Attachment #9548239 - Flags: approval-mozilla-release? → approval-mozilla-release+
Duplicate of this bug: 2022075

This is also verified as fixed on macOS 26 and Win 11 with Firefox 148.0.2 (20260309125808).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: