Closed Bug 2010761 Opened 10 months ago Closed 9 months ago

Website is not refreshed when removing it from the exclusion list

Categories

(Firefox :: IP Protection, defect, P1)

Firefox 149
Desktop
Windows 10
defect
Points:
3

Tracking

()

RESOLVED WONTFIX
149 Branch
Tracking Status
firefox149 --- affected

People

(Reporter: vvalentina, Assigned: kpatenio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fx-vpn][qe-verify])

Attachments

(1 external file)

[Affected versions]:

  • Firefox Nightly 149.0a1 (2026-01-15);

[Affected Platforms]:

  • Windows 10 x64;

[Prerequisites]:

  • Be enrolled into the experiment;
  • Have the “Browser.ipProtection.features.siteExceptions” pref set to true;
  • Have YT added to the exclusion list;

[Steps to reproduce]:

  1. Click the Firefox VPN toolbar icon and turn it ON;
  2. Have YouTube website opened (with the messaging add-on NOT displayed)
  3. Go to the Firefox VPN section from the about:preferences#privacy page;
  4. Click on “Manage websites settings” to open the Site Exclusions modal;
  5. Remove YT from the list of exclusions and click on the “Save Changes” button;
  6. Go back to the YouTube website tab;
  7. Observe the website;

[Expected result]:
The website is refreshed and the messaging add-on is displayed as the website was removed from the exclusion list.

[Actual result]:
The website is not refreshed and the messaging add-on is not displayed.

[Notes]:
Opening the website in a new window or manually refreshing the page will trigger the messaging add-on back.

Blocks: 2004517
Whiteboard: [fx-vpn]
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Priority: -- → P1
Points: --- → 3
Pushed by kpatenio@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/39adebd6b3ce https://hg.mozilla.org/integration/autoland/rev/5d237185bd83 — reload pages after interacting with IPP site exclusion toggle. r=ip-protection-reviewers,fchasen
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch

Hi QA team,

This is ready to be reviewed at your earliest convenience. Interacting with the "Use VPN for this site" toggle should now refresh the currently loaded tab, similarly to how the turn on/off toggle works for the VPN.

Thanks!

Whiteboard: [fx-vpn] → [fx-vpn][qe-verify]

Verified this on Firefox Nightly 149.0a1 (23-01-26) on Windows 10.
The messaging add-on is still not displayed after removing YT from the exclussion list (step 5).
The toolbar icon is refreshed and the correct dot (entirely green).
Manually refreshing the page, brings back the messaging add-on.

Viceversa, if we add YT to the exclussion list, the messaging add-on is immediatelly displayed, without the need of manually refreshing the page.
This fixed from VPN toolbar icon point of view, but not from the messaging add-on part. (why it was initially logged)

Flags: needinfo?(amarchesini)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

The website is not reloaded if the website is excluded/included from about:preferences. The patch is just about the interaction with the panel and it has to be fixed to cover this STR.

Flags: needinfo?(amarchesini) → needinfo?(kpatenio)

(In reply to Valentina Virlics [:vvalentina], VPN QA from comment #5)

Verified this on Firefox Nightly 149.0a1 (23-01-26) on Windows 10.
The messaging add-on is still not displayed after removing YT from the exclussion list (step 5).
The toolbar icon is refreshed and the correct dot (entirely green).
Manually refreshing the page, brings back the messaging add-on.

Viceversa, if we add YT to the exclussion list, the messaging add-on is immediatelly displayed, without the need of manually refreshing the page.
This fixed from VPN toolbar icon point of view, but not from the messaging add-on part. (why it was initially logged)

Hi Valentina, thanks for flagging this. I had only thought of reloading sites after pressing the toggle on the panel. I completely missed the requirement for reloading sites after excluding/including via about:preferences. I'll work on a follow up patch to address this.

Flags: needinfo?(kpatenio)

Thanks for flagging this, we hadn't discussed it previously but after going over it the tabs should not refresh when exclusions are changed via settings for now.

We only reload the current in use tab when turning the VPN on or off and same for the tab the the exclusions state is toggled on or off from the panel. Reloading when settings are changed would need to reload every instance of that domain in any tab which would be inconsistent from the other reloads.

We might want to message the user to choose to reload in the future though.

Status: REOPENED → RESOLVED
Closed: 10 months ago → 9 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: