2010905 - generated chat titles fall back to generic default titles

Status: RESOLVED FIXED

(Core :: Machine Learning: General, defect)

Description

[Ed Lee :Mardak]

i noticed the response actually looks like { finalOutput: "Seattle weather overview", metrics: [] }

whereas the code is expecting { choices: … } https://searchfox.org/firefox-main/rev/d7705da6d7dcd579f166202df87ffd38aac5f89d/browser/components/aiwindow/models/TitleGeneration.sys.mjs#67,75

Comment 1

[Ed Lee :Mardak]

oh, it's a non-streaming response, so the result is packaged up differently

https://searchfox.org/firefox-main/rev/d7705da6d7dcd579f166202df87ffd38aac5f89d/toolkit/components/ml/content/backends/OpenAIPipeline.mjs#288-290,303

Comment 2

[mzhang]

Attachment: Bug 2010905 - fix title generation bug r?mardak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/849b6284b648
https://hg.mozilla.org/integration/autoland/rev/a392da0c7406
fix title generation bug r=Mardak,ai-models-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a392da0c7406