Open Bug 2010985 Opened 1 day ago

[wpt-sync] Sync PR 57222 - Don't run Stable channel Edge with experimental flag

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 57222 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/57222
Details from upstream follow.

Daniel Clark <daniec@microsoft.com> wrote:

Don't run Stable channel Edge with experimental flag

https://github.com/web-platform-tests/wpt/pull/52651 made changes to how Chrome's --web-platform-experimental-features flag gets set, which had the side-effect of causing Edge to always use this flag even in Stable channel runs.

This is because with https://github.com/web-platform-tests/wpt/pull/52651, Chrome's executor_kwargs, which is also used by Edge, requires kwargs["enable_experimental"] to have a value in order to not apply experimental flags by default. The same change caused the value to be set in Chrome's setup_kwargs, but since that code is not shared for Edge, the missing value for Edge's kwargs["enable_experimental"] causes the experimental flag to be set.

Fix the issue by refactoring the Chrome and Edge BrowserSetup classes so that they both set kwargs["enable_experimental"], and share other common logic to lower the likelihood of similar issues in the future.

While looking at this I also noticed a divergence in --headless behavior introduced in https://github.com/web-platform-tests/wpt/pull/44515. Filed #57221 to track that.

Closes #55905.

You need to log in before you can comment on or make changes to this bug.