2011081 - Page Info saves file instead of preview

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect, P3)

Description

[tkzv]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:147.0) Gecko/20100101 Firefox/147.0

Steps to reproduce:

1. Open page https://t.me/expensive_hurma/31926
2. Ctrl-I to open "Page Info".
3. Switch to "Media" tab.
4. Switch to the list of files.
5. Browse the list with arrows and clicks.
6. Switch to the bottom file at https://cdn4.telesco.pe/ domain (currently https://cdn4.telesco.pe/file/fbc3125735.webp?token=...)

Actual results:

On step 5 preview works correctly for most files. On step 6 the image is instead saved to the default directory and opened in a new browser tab using file:// protocol

This may have something to do with the reported "content-type" header: the problematic file is "application/octet-stream", the rest are "image/png", "image/jpeg", "image/svg+xml", "image/x-icon".

Expected results:

Earlier versions (before 140) correctly displayed previews for this file.

Comment 1

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=ea419ed5f578721b0252c8d13737903c536dd924&tochange=1dbd75f09e1653f81fe3d06a8f99eb9485aa0100

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:tschuster, since you are the author of the regressor, bug 1980376, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Tom Schuster]

We really shouldn't be starting downloads here and instead show a broken image. I actually thought that is how it worked already.

Comment 4

[tkzv]

(In reply to Tom Schuster (MoCo) from comment #3)

We really shouldn't be starting downloads here and instead show a broken image.

The old versions displayed the image.

Comment 5

[Tom Schuster]

Attachment: Bug 2011081 - Do not start download for unhandled content in the Page Info media preview. r?#necko-reviewers

Comment 7

[Tom Schuster]

We should maybe think about having this as a dot fix ride along.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a38747d111a
https://hg.mozilla.org/integration/autoland/rev/e28dfb4432ff
Do not start download for unhandled content in the Page Info media preview. r=necko-reviewers,jesup

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b746430d0f05
https://hg.mozilla.org/integration/autoland/rev/db4bc2e8b578
Revert "Bug 2011081 - Do not start download for unhandled content in the Page Info media preview. r=necko-reviewers,jesup" for causing build bustage at nsURILoader.cpp

Comment 10

[Cristina Horotan [:chorotan]]

Backed out for causing build bustage at nsURILoader.cpp

Backout link

Push with failures

Failure log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45c9d2b23bf0
https://hg.mozilla.org/integration/autoland/rev/a5d91e8c7a22
Do not start download for unhandled content in the Page Info media preview. r=necko-reviewers,jesup

Comment 12

[Tom Schuster]

Attachment: Bug 2011081 - Don't trigger a download for octect-stream when loading with forceMediaDocument: image. r?jesup

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a5d91e8c7a22

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tschuster, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox148 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/13c2ee378f5b
https://hg.mozilla.org/integration/autoland/rev/fb8fc973f8e0
Don't trigger a download for octect-stream when loading with forceMediaDocument: image. r=jesup

Comment 16

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/fb8fc973f8e0

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fb8fc973f8e0

Comment 18

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: The page info dialog is relatively obscure, but the behavior is very annoying for people that run into it. Triggering a download is quite unexpected behavior when trying to preview media.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The patch is very simple and will only affect the Page Info window.
• String changes made/needed: no
• Is Android affected?: no

Comment 19

[Tom Schuster]

Attachment: Bug 2011081 - Do not start download for unhandled content in the Page Info media preview.

Original Revision: https://phabricator.services.mozilla.com/D283707

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/35bc0143c807
https://hg.mozilla.org/releases/mozilla-release/rev/fe9010de182d