Open Bug 2011397 Opened 7 months ago Updated 6 months ago

CookieService::GetCookieStringFromHttp is very inefficient

Categories

(Core :: Networking: Cookies, enhancement, P2)

Product:
Core
Component:
Networking: Cookies
Type:
enhancement
Points:
3

Tracking

()

People

(Reporter: valentin, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [necko-triaged] [necko-priority-next])

Attachments

(1 file)

WIP: Bug 2011397 - Cache cookiePermission in GetCookieStringFromHttp r=edgul
48 bytes, text/x-phabricator-request
Details | Review

See https://share.firefox.dev/4b2neki
It seems CookieService::GetCookieStringFromHttp calls into CookieJarSettings::CookiePermission via 3 different code paths, and consumes 26% of time spent on the main thread.

  • ThirdPartyUtil::AnalyzeChannel
  • mozilla::StoragePrincipalHelper::GetOriginAttributes
  • mozilla::net::CookieService::GetCookiesForURI
    Bug 2009490 optimized BasePrincipal::EqualsForPermission, but that GetCookieStringFromHttp is still slow.
    I think we should be able to create the cookiePermission just once, and pass it into these functions.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: