2011478 - try generating memories when activating ai window

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement, P1)

Description

[Ed Lee :Mardak]

bug 2010143 added conditions for generating memories such as checking for tos and active ai window with a MemoriesSchedulers.maybeRunAndSchedule api

we should trigger memory scheduling and kick off memory generation when the user activates an ai window which would have required the user to accept terms, so maybe when hasToSConsent gets set https://searchfox.org/firefox-main/rev/93aad2a6615f670b1279c229dd37f7397236131a/browser/components/aiwindow/ui/modules/AIWindowAccountAuth.sys.mjs#91

i don't think we need to wait for firstrun completion as the model we use for memories is independent of assistant response model?

more generally, we should probably trigger potential memory generation (it handles its own "too recent" backoff heuristics) whenever we checked if we need to show firstrun bug 2005368? https://searchfox.org/firefox-main/rev/93aad2a6615f670b1279c229dd37f7397236131a/browser/components/aiwindow/ui/modules/AIWindow.sys.mjs#363-374

we also need to flip the default pref value to true https://searchfox.org/firefox-main/rev/93aad2a6615f670b1279c229dd37f7397236131a/browser/app/profile/firefox.js#2270

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 2011478 - Generate memories when activating ai window

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4d46231ad5ac
https://hg.mozilla.org/integration/autoland/rev/e6ba8192d151
Generate  memories when activating ai window r=ai-frontend-reviewers,Mardak

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e6ba8192d151