Closed
Bug 201150
Opened 21 years ago
Closed 21 years ago
force use of detected tools
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: netscape, Assigned: netscape)
Details
Attachments
(1 file, 1 obsolete file)
|
10.65 KB,
patch
|
bryner
:
review+
|
Details | Diff | Splinter Review |
We do a number of configure tests for versions of various tools but we never force the use of those tools at runtime. We just use whatever's first in the path which means that overriding certain tools by passing env variables to configure doesn't work. In particular, MAKE & ZIP are not propagated correctly.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #120042 -
Flags: review?(bryner)
|
||
Updated•21 years ago
|
Attachment #120042 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Comment 2•21 years ago
|
||
The previous patch failed on msvc builds because we skipped all of the tool detection steps. Now we check the tool paths on all platforms. Cygwin's version of makedepend (from XFree86 4.2.0) fails when building dependencies in activex. It complains that it cannot open the directory "../../../dist/include/string" for reading. It looks like it's running into that old gcc3 bug which caused builds to fail whenever someone included the standard c++ header <string> . For now, I've disabled using the system makedepend on win32.
Attachment #120042 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #120177 -
Flags: review?(bryner)
|
|
||
Updated•21 years ago
|
Attachment #120177 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Patch has been checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.4beta
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•