Closed
Bug 2011709
Opened 7 months ago
Closed 7 months ago
Switch to a shadow root to render the nsComboboxControl selected content and arrow.
Categories
(Core :: Layout: Form Controls, enhancement, P3)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 2011709 - Make combobox select use a shadow tree for its contents. r=keithamus,jjaschke,#layout!
48 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
| Assignee | ||
Comment 1•7 months ago
|
||
To be clear this would be a matter of replacing these two elements: https://searchfox.org/firefox-main/rev/ba7a7a320649794a9948b32156f5b438fef5ce7a/layout/forms/nsComboboxControlFrame.h#119-123 by something created on the DOM side for combobox selects.
These rules also need tweaking.
| Assignee | ||
Comment 2•7 months ago
|
||
For now, replicate the label + button structure.
TODO: Make the displayed text stuff managed by the DOM.
Updated•7 months ago
|
Assignee: nobody → emilio
Attachment #9539379 -
Attachment description: WIP: Bug 2011709 - Make combobox select use a shadow tree for its contents. → Bug 2011709 - Make combobox select use a shadow tree for its contents. r=keithamus,jjaschke,#layout!
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/402146477384
https://hg.mozilla.org/integration/autoland/rev/b967fdc6fff3
Make combobox select use a shadow tree for its contents. r=jjaschke,layout-reviewers,firefox-style-system-reviewers,accessibility-platform-reviewers,smaug,Jamie,jfkthame,dshin
Comment 5•7 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox149:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
Regressions: 2014615
Updated•6 months ago
|
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in
before you can comment on or make changes to this bug.
Description
•