2011727 - Autocomplete listboxes for bugzilla looks rather odd

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screenshot

See screenshot on Linux. I don't think that's the intended behavior. Was it intended to affect only password / etc autocomplete?

Comment 1

[Micah [:mtigley] (she/her)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #0)

Created attachment 9539159 [details]
Screenshot

See screenshot on Linux. I don't think that's the intended behavior. Was it intended to affect only password / etc autocomplete?

These changes were for passwords, form history, credit cards, addresses etc. autocomplete dropdowns specifically.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

It seems they affected the form history dropdowns too tho, see the screenshot

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screenshot of login autocomplete

Even those look rather off here btw.

Comment 4

[Sören Hentzschel]

Also, on macOS, all autocomplete dropdown menus now have a scroll bar for no apparent reason.

Comment 5

[Sören Hentzschel]

Attachment: scrollbar

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Micah should we back out the regressing bug for now?

Comment 7

[Micah [:mtigley] (she/her)]

Hm, I wonder if we can set the maxHeight of the popup to scrollHeight here? It seems to work locally.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

That would not allow the popup to scroll if it overflows would it? It seems that you need to handle the richlistitem margins here, or remove the margin.

Comment 9

[Micah [:mtigley] (she/her)]

Attachment: Bug 2011727 - Account for row margins when determining height of autocomplete popup box. r=dimi!

Comment 10

[Manuel Bucher [:manuel]]

Moving bug 2008963 to "regressed by" to better reflect bug relation.

Comment 11

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2008963

Comment 12

[Jeremy Swinarton]

Attachment: Bug 2011727: Tab notes validates partial and malformed canonical URLs r?dwalker,sthompson

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d814a2f15755
https://hg.mozilla.org/integration/autoland/rev/68e0315328c1
Account for row margins when determining height of autocomplete popup box. r=dimi,desktop-theme-reviewers,dao

Comment 14

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/68e0315328c1