2011733 - Refactor `TabsTrayState`'s tab data models for Normal, Private, and Inactive

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, task, P1)

Description

[Noah Bond [:007]]

In order to have different items within the Tab Manager, we'll need to have a wrapper abstraction around the tab data so we can support/display any number of item types.

We also duplicate a ton of tab data by keeping exact copies of every TabSessionState when we should instead only have the data necessary to render the Tab Manager.

As part of this ticket:

• Create a sealed class parent type along the lines of TabItem
• Created a sealed class child type along the lines of Tab to represent the new tab data model.
• Create a sealed class child type for synced tabs.
• Trim down the tab data retained in TabsTrayState, so it only has the data properties used to render the Tab Manager.

https://searchfox.org/firefox-main/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayStore.kt#45,47-48

Comment 1

[Noah Bond [:007]]

Attachment: Bug 2011733 - Part 1 - Migrate `Page` to its own file

Comment 2

[Noah Bond [:007]]

Attachment: Bug 2011733 - Part 2 - Migrate `TabsTrayState` to its own file

Comment 3

[Noah Bond [:007]]

Attachment: Bug 2011733 - Part 3 - Migrate `TabsTrayAction`, `TabGroupAction`, and `TabSearchAction` to their own files

Comment 4

[Noah Bond [:007]]

Attachment: Bug 2011733 - Part 4 - Move `TabsTrayStore` into `tabstray/redux/store`

Comment 5

[Noah Bond [:007]]

Attachment: Bug 2011733 - Part 5 - Move `TabsTrayReducer` into its own file

Comment 6

[Noah Bond [:007]]

Attachment: Bug 2011733 - Part 6 - Refactor `TabsTrayState` to use a generic item type

Comment 7

[Noah Bond [:007]]

Attachment: Bug 2011733 - Part 7 - Filter down the tabs tray tab data to only the necessary parts

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/264aeb5c47a8
https://hg.mozilla.org/integration/autoland/rev/b7aa8522c5e2
Part 1 - Migrate `Page` to its own file r=android-reviewers,calu
https://github.com/mozilla-firefox/firefox/commit/02cca3e031c7
https://hg.mozilla.org/integration/autoland/rev/76191fb5dd05
Part 2 - Migrate `TabsTrayState` to its own file r=android-reviewers,calu
https://github.com/mozilla-firefox/firefox/commit/19b4f40bbaa4
https://hg.mozilla.org/integration/autoland/rev/829a4281fd18
Part 3 - Migrate `TabsTrayAction`, `TabGroupAction`, and `TabSearchAction` to their own files r=android-reviewers,calu
https://github.com/mozilla-firefox/firefox/commit/196090d53f25
https://hg.mozilla.org/integration/autoland/rev/7ca7f5a74395
Part 4 - Move `TabsTrayStore` into `tabstray/redux/store` r=android-reviewers,calu
https://github.com/mozilla-firefox/firefox/commit/069a4c74a214
https://hg.mozilla.org/integration/autoland/rev/078f1b187f1e
Part 5 - Move `TabsTrayReducer` into its own file r=android-reviewers,calu

Comment 9

[rperta]

https://hg.mozilla.org/mozilla-central/rev/b7aa8522c5e2
https://hg.mozilla.org/mozilla-central/rev/76191fb5dd05
https://hg.mozilla.org/mozilla-central/rev/829a4281fd18
https://hg.mozilla.org/mozilla-central/rev/7ca7f5a74395
https://hg.mozilla.org/mozilla-central/rev/078f1b187f1e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e901ccc5826f
https://hg.mozilla.org/integration/autoland/rev/b159eecae610
Part 6 - Refactor `TabsTrayState` to use a generic item type r=android-reviewers,calu
https://github.com/mozilla-firefox/firefox/commit/37517e6657bc
https://hg.mozilla.org/integration/autoland/rev/3c89e9a9eb58
Part 7 - Filter down the tabs tray tab data to only the necessary parts r=android-reviewers,jdelorenzo

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/679541fd4c89
https://hg.mozilla.org/integration/autoland/rev/a3105f5a1c6b
Revert "Bug 2011733 - Part 7 - Filter down the tabs tray tab data to only the necessary parts r=android-reviewers,jdelorenzo" for causing fenix failures.

Comment 12

[Atila Butkovits]

Backed out for causing fenix failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a3105f5a1c6b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3c89e9a9eb58101ce67453d01919c58ed5d32ab4&selectedTaskRun=JM_CEQo5RYmVJMVgBAg7Vw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=550944062&repo=autoland&task=JM_CEQo5RYmVJMVgBAg7Vw.0&lineNumber=543

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f552c8c6e442
https://hg.mozilla.org/integration/autoland/rev/d2acbe9033db
Part 6 - Refactor `TabsTrayState` to use a generic item type r=android-reviewers,calu
https://github.com/mozilla-firefox/firefox/commit/30ec465fe402
https://hg.mozilla.org/integration/autoland/rev/d6d34899c62a
Part 7 - Filter down the tabs tray tab data to only the necessary parts r=android-reviewers,jdelorenzo

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d2acbe9033db
https://hg.mozilla.org/mozilla-central/rev/d6d34899c62a