2012083 - [meta] If Firefox crashes during exit, FELT should not restart Firefox

Status: RESOLVED FIXED

(Enterprise Products :: Firefox, defect, P1)

Description

[jmendez]

Currently Felt will restart Firefox on an abnormal exit (crash). However, if the user is trying to exit Firefox already (i.e. the crash happens during shutdown), we should not restart Firefox.

• I encountered this scenario in a local build (no crash reporter) and was frustrated because I could not quit Firefox.
• In an installed build with crash reporter, we need to define the expected behavior (crash reporter dialog currently gives option to quit or restart, but Felt may not be waiting for the crash reporter dialog).

We could potentially send a "starting to exit" signal to Felt when the user initiates the exit.

Comment 1

[:gerard-majax]

(In reply to jmendez from comment #0)

Currently Felt will restart Firefox on an abnormal exit (crash). However, if the user is trying to exit Firefox already (i.e. the crash happens during shutdown), we should not restart Firefox.

• I encountered this scenario in a local build (no crash reporter) and was frustrated because I could not quit Firefox.
• In an installed build with crash reporter, we need to define the expected behavior (crash reporter dialog currently gives option to quit or restart, but Felt may not be waiting for the crash reporter dialog).

We could potentially send a "starting to exit" signal to Felt when the user initiates the exit.

Pretty sure we already do

edit: we do intercept but only notify restart: https://enterprise-test.searchfox.org/enterprise-main/rev/fc98b717f157e6287da2b87bd86090a94703cdc8/browser/extensions/felt/rust/src/client.rs#197-239

Comment 2

[:gerard-majax]

related: https://bugzilla.mozilla.org/show_bug.cgi?id=2012080

Comment 3

[:gerard-majax]

Attachment: GitHub Pull Request

I dont have a case of shutdown crash, but this should help?

It's based on not-yet-merged-mc because we are still waiting on tasks ...

Comment 4

[jmendez]

I was able to instrument a shutdown crash and test your changes. Before your change, the firefox client restarts. After your change, the firefox client and felt process exit, as expected. I tested with crashreporter enabled, and it appeared as expected (until we change that behavior).

Comment 5

[:gerard-majax]

Attachment: Bug 2012083 - Allow setting crash shutdown additional wait time from pref r?gsvelto!

Comment 6

[BMO Github Automation]

Authored by Alexandre Lissy
https://github.com/mozilla/enterprise-firefox/commit/8404f7aeb7b31027c85827242b827e6a69185de7
[enterprise-main] Bug 2012083 - Allow setting crash shutdown additional wait time from pref r?gsvelto!

Authored by Alexandre Lissy
https://github.com/mozilla/enterprise-firefox/commit/e44519ec7e36f11232d144bca79a2812fa5cf7d2
[enterprise-main] Bug 2012083 - Enterprise: notify FELT of shutdown

Authored by Alexandre Lissy
https://github.com/mozilla/enterprise-firefox/commit/fa7874c8c5c1ae404bbac27a3d1dfb3079d7c6fa
[enterprise-main] Bug 2012083 - Enterprise: add test for shutdown crash handling

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a79d16853458
https://hg.mozilla.org/integration/autoland/rev/90f8784753f7
Allow setting crash shutdown additional wait time from pref r=gsvelto

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/90f8784753f7