2012636 - [HCM] Splitview icon button adjustments

Status: NEW

(Firefox :: Tabbed Browser: Split View, defect, P3)

Description

[Natalie Stroud [:nstroud]]

Ways to turn on Split View:

1 tab method
Open Firefox Nightly
Open any website
Open a tab context menu on any tab in the tab strip
Select ‘Add Split View’

2 tab method
Open Firefox Nightly
Open two websites in two separate tabs
In the tab strip, select one tab and press Ctrl + SPACE + left/right arrow key to select the second tab
Open the tab context menu
-for keyboard on Windows, you'll want to press fn + Shift + F10 to get to the context menu
Select ‘Add Split View’

STR:

Please note: it is important to turn HCM on first and then open Nightly. Otherwise, you may be unable to replicate the issue

1. Turn on Windows Night Sky
2. Open Firefox Nightly
3. Turn on split view using one of the methods above

Expected / Actual:

The icon button should follow the same stylings as the icon button HCM styles found here in Figma

DEFAULT:
ButtonFace background
ButtonText icon
ButtonText border

HOVER:
SelectedItemText background
SelectedItem icon
SelectedItem border

ACTIVE:
SelectedItemText background
SelectedItem text
ButtonText border

FOCUS:
ButtonFace background
ButtonText text
ButtonText border
CanvasText focus outline

Comment 1

[Natalie Stroud [:nstroud]]

Attachment: Default HCM of icon buttons in URL bar

Comment 2

[Natalie Stroud [:nstroud]]

Attachment: Hover HCM style of icon button in URL bar

Comment 3

[Natalie Stroud [:nstroud]]

Attachment: Focus HCM style of icon button in URL bar

Comment 4

[Natalie Stroud [:nstroud]]

Attachment: Active HCM style of icon button in URL bar

Comment 5

[Sarah Clements [:sclements] | PTO until March 30th]

This should all be consistent as part of nova so holding off for now.