2012740 - [wptrunner] Extra preferences as specified via "--setpref" should not be overwritten with required preferences

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While working on bug 1998347 I put the preference for enabling async mouse events as a required preference into wptrunner. When investigating issues by using the --setpref argument of ./mach wpt I saw that the value as specified always gets overwritten by the required prefs one. As such I'm not able to force the preference to be disabled.

As it can be seen at the following file we first set the extra preferences and then apply the required prefs on top:
https://searchfox.org/firefox-main/source/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py#708,714,748

We should get this fixed so that the extra prefs actually have higher priority.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 2012740 - [wptrunner] Refactor preference building and fix override precedence.

Restructure preference handling to build all preferences before profile creation,
ensuring extra_prefs are applied last with proper type casting for correct override
behavior. Split logic into _get_base_prefs(), _get_test_type_prefs(), and
_get_debug_prefs() for better code organization and maintainability.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/707e81439f02
https://hg.mozilla.org/integration/autoland/rev/e51fa869fc5c
[wptrunner] Refactor preference building and fix override precedence. r=jgraham

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57427 for changes under testing/web-platform/tests

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e51fa869fc5c

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by whimboo

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/197da7bddb16
https://hg.mozilla.org/integration/autoland/rev/2624fb1494ad
[wpt PR 57427] - [Gecko Bug 2012740] [wptrunner] Refactor preference building and fix override precedence., a=testonly

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2624fb1494ad