2012824 - Widget telemetry events pass wrong value to newtab_visit_id

Status: ASSIGNED

(Firefox :: New Tab Page, defect)

Description

[Maxx Crawford [:maxx]]

In both the following instances, it should pass session.session_id to newtab_visit_id.

https://searchfox.org/firefox-main/source/browser/extensions/newtab/lib/TelemetryFeed.sys.mjs#1428
https://searchfox.org/firefox-main/source/browser/extensions/newtab/lib/TelemetryFeed.sys.mjs#1407

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 2012824 - Update widget telemetry events to pass the correct value to newtab_visit_id. r?#home-newtab-reviewers

The handlePromoCardUserEvent and handleWidgetsUserEvent methods were incorrectly accessing session.visit_id, which doesn't exist. The correct property is session.session_id. This bug caused these telemetry events to send undefined for the newtab_visit_id field.