201294 - showdependencygraph.cgi uses a hard-coded list of open states

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Dave Miller [:justdave]]

It should use the global IsOpenedState() sub instead to make it easier on sites
that hack the available statuses (like Zippy :)

Patch coming.

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 119933 [details] [diff] [review]
Patch

>-    if ($stat =~ /^(NEW|ASSIGNED|REOPENED)$/) {
>+    if (IsOpenedState($stat)) {

This actually changed behaviour; it now includes UNCONFIRMED, when it didn't
before. Is that a bug fix, or an unintentional side-effect?

If the former, r=gerv.

Gerv

Comment 3

[Dave Miller [:justdave]]

I would say that was an oversight when UNCONFIRMED was added, and thus it's a
bugfix. :)

Comment 4

[Dave Miller [:justdave]]

Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <-- 
showdependencygraph.cgi
new revision: 1.30; previous revision: 1.29
done