Closed Bug 201294 Opened 17 years ago Closed 16 years ago

showdependencygraph.cgi uses a hard-coded list of open states

Categories

(Bugzilla :: Reporting/Charting, defect)

2.17.3
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: justdave, Assigned: justdave)

Details

Attachments

(1 file)

It should use the global IsOpenedState() sub instead to make it easier on sites
that hack the available statuses (like Zippy :)

Patch coming.
Attachment #119933 - Flags: review?(gerv)
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 119933 [details] [diff] [review]
Patch

>-    if ($stat =~ /^(NEW|ASSIGNED|REOPENED)$/) {
>+    if (IsOpenedState($stat)) {

This actually changed behaviour; it now includes UNCONFIRMED, when it didn't
before. Is that a bug fix, or an unintentional side-effect?

If the former, r=gerv.

Gerv
I would say that was an oversight when UNCONFIRMED was added, and thus it's a
bugfix. :)
Attachment #119933 - Flags: review?(gerv) → review+
Status: NEW → ASSIGNED
Flags: approval?
Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <-- 
showdependencygraph.cgi
new revision: 1.30; previous revision: 1.29
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: approval? → approval+
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.