Closed Bug 2013312 Opened 5 months ago Closed 5 months ago

Remove (activity as HomeActivity) casts in StartupTimeline.kt

Categories

(Firefox for Android :: Homepage, task)

Firefox 149
All
Android
task

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: azinovyev, Assigned: azinovyev)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert, Whiteboard: [fxdroid][group6])

Attachments

(1 file)

No description provided.
Summary: Remove (activity as HomeActivity) casts in SessionControlController.kt → Remove (activity as HomeActivity) casts in StartupTimeline.kt
Pushed by azinovyev@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/24b3a20dfcd4 https://hg.mozilla.org/integration/autoland/rev/a0b3b185c111 Remove (activity as HomeActivity) casts in StartupTimeline.kt r=android-reviewers,jonalmeida
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch

(In reply to Pulsebot from comment #2)

Pushed by azinovyev@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/24b3a20dfcd4
https://hg.mozilla.org/integration/autoland/rev/a0b3b185c111
Remove (activity as HomeActivity) casts in StartupTimeline.kt
r=android-reviewers,jonalmeida

Perfherder has detected a browsertime performance change from push a0b3b185c11153f04cc600403b4e1210a5635c1d.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
10% wikipedia fcp (doc) android-hw-a55-14-0-aarch64-shippable cold webrender 319.66 ms -> 286.21 ms
10% wikipedia loadtime (doc) android-hw-a55-14-0-aarch64-shippable cold webrender 482.17 ms -> 434.53 ms
7% sina FirstVisualChange (doc) android-hw-a55-14-0-aarch64-shippable cold webrender 802.89 ms -> 744.39 ms
4% sina PerceptualSpeedIndex (doc) android-hw-a55-14-0-aarch64-shippable cold webrender 1,470.00 ms -> 1,406.02 ms
3% sina ContentfulSpeedIndex (doc) android-hw-a55-14-0-aarch64-shippable cold webrender 2,352.51 ms -> 2,283.78 ms

Need Help or Information?

If you have any questions, please reach out to afinder@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
Regressions: 2021282
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: