2013405 - Clean up Pocket sponsored stories use cases

Status: ASSIGNED

(Firefox for Android :: Stories, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

We have replaced the old Pocket sponsored stories with the Unified Ads API. The task is to remove any existing use cases that involves fetching the Pocket sponsored stories.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2013405 - Part 1: Remove Pocket to MARS profile migration code in Fenix

• This code to delete Pocket profile on enrolment of the MARS API was added in Bug 1946345
• It has been over close to 1 year since this migration code was added to allow for the safe transition of existing Pocket profile to MARS. This is no longer needed given the Pocket services have been deprecated and we are OK with creating new MARS profile.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2013405 - Part 2: Remove workers involved with Pocket sponsored stories

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2013405 - Part 3: Remove Pocket Spocs Integration from Fenix

Remove legacy Pocket sponsored stories (spocs) integration from Fenix UI and state management. This code has been superseded by the MARS (Mozilla Ad Routing Service) sponsored content.

Changes:

• Removed pocketSponsoredStories field from ContentRecommendationsState
• Removed PocketSponsoredStoriesChange action from AppAction
• Updated ContentRecommendationsReducer to remove spocs handling
• Removed useSponsoredStoriesState parameter and getFilteredSponsoredStories() from AppState.kt
• Updated PocketMiddleware to remove spocs impression recording
• Removed PocketSponsoredStory handling from PocketStoriesController
• Updated UI components (Stories.kt, StoryCard.kt) to remove spocs display logic
• Removed legacy spocs settings: pocketSponsoredStoriesProfileId, pocketSponsoredStoriesSiteId, pocketSponsoredStoriesCountry, pocketSponsoredStoriesCity
• Removed Profile and sponsoredStoriesParams from Core.kt PocketStoriesConfig
• Deleted SponsoredStoriesSettingsFragment and related navigation
• Updated tests to remove spocs-related test cases

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2013405 - Part 4: Remove Pocket Spocs orchestration from android-components

Remove the Pocket Spocs orchestration for legacy sponsored stories, including use cases, repository, API layer, and data types.

Changes:

• Removed spocsUseCases property from PocketStoriesService
• Removed methods: refreshSponsoredStories(), getSponsoredStories(), recordStoriesImpressions(), deleteProfile()
• Removed SponsoredStories object from GlobalDependencyProvider
• Deleted entire spocs/ directory containing:
  • SpocsUseCases.kt with use cases for getting and refreshing spocs
  • SpocsRepository.kt for data access
  • API layer: SpocsEndpoint.kt, SpocsEndpointRaw.kt, SpocsProvider.kt, SpocsJSONParser.kt, ApiSpoc.kt
  • Database layer: SpocsDao.kt
• Updated tests to remove spocs-related test cases

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 2013405 - Part 5: Remove unused Pocket consumer key from BuildConfig

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b971f108a64b
https://hg.mozilla.org/integration/autoland/rev/edfec6d27977
Part 1: Remove Pocket to MARS profile migration code in Fenix r=android-reviewers,devota
https://github.com/mozilla-firefox/firefox/commit/c206271d981e
https://hg.mozilla.org/integration/autoland/rev/0aed7c2fd1d8
Part 2: Remove workers involved with Pocket sponsored stories r=android-reviewers,devota

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/edfec6d27977
https://hg.mozilla.org/mozilla-central/rev/0aed7c2fd1d8

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd6583e8c34a
https://hg.mozilla.org/integration/autoland/rev/c82e658b3222
Part 5: Remove unused Pocket consumer key from BuildConfig r=android-reviewers,petru

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a638db7dc1e1
https://hg.mozilla.org/integration/autoland/rev/376542f8131f
Revert "Bug 2013405 - Part 5: Remove unused Pocket consumer key from BuildConfig r=android-reviewers,petru" for causing fenix debug failures

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing fenix debug failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/376542f8131f87897534df84ca26e03c00ff575b

Push with failures

Failure log -> file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt:576:37: error: Unresolved reference 'POCKET_CONSUMER_KEY