2013470 - [wpt-sync] Sync PR 57409 - Don't require a LayoutObject when 'src' changes on an embed

Status: NEW

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 57409 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/57409
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Don't require a LayoutObject when 'src' changes on an embed

When an embed element has no 'src' and no 'type', it represents
nothing. When the 'src' would be changed to non-empty in that state
there would be no LayoutObject, and thus attach was not triggered
for the element.

By-pass the check for a LayoutObject in this case.

Guarded by the "HTMLEmbedElementRepresentsNothingToActive" flag.

Fixed: 479233864
Change-Id: If5bf5cc2684e146dfc56dda02f12e930a134a717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524670
Commit-Queue: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1576496}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests and 1 subtests

Status Summary

Firefox

OK : 1[GitHub] 15[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS : 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, GitHub] 23[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 27[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL : 1[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

TIMEOUT: 2

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/embedded-content/the-embed-element/embed-hidden-attribute.html [wpt.fyi]: FAIL
• /html/semantics/embedded-content/the-embed-element/embed-network-error.sub.html [wpt.fyi]: SKIP
• /html/semantics/embedded-content/the-embed-element/embed-represent-nothing-04.html [wpt.fyi]
  • ensure the element represents nothing: FAIL

Tests Disabled in Gecko Infrastructure

• /html/semantics/embedded-content/the-embed-element/embed-network-error.sub.html [wpt.fyi]: SKIP linked bug:Bug 1653034