2013700 - PiP video on disneyplus.com lacks certain controls

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[The_Blinded]

Attachment: Disneyplus PIP

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:147.0) Gecko/20100101 Firefox/147.0

Steps to reproduce:

I opened a video on disneyplus.com in picture-in-picture mode.

Actual results:

Picture-in-picture mode starts correctly but without some controls in the interface: forward/backward 5 seconds, playback progress bar, elapsed time, and total time.

Expected results:

Display all controls as on other sites (e.g., Netflix)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mconley, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[kpatenio]

Likely PiP is incorrectly reading disney plus videos as "live" and hiding the other video controls. This would require an update to our disney plus video wrapper to detect the correct isLive state.

Update: more specifically, video is likely returning Infinity in https://searchfox.org/firefox-main/rev/eea0f8f080f0eb810c0c6296da9792e81cd69ce6/toolkit/actors/PictureInPictureChild.sys.mjs#3320. Thanks to Niklas for pointing that out!

Comment 4

[Niklas Baumgardner [:niklas]]

Attachment: Bug 2013700 - Update disney plus wrapper so all controls work. r=#pip-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3d073a15703d
https://hg.mozilla.org/integration/autoland/rev/0339d8c493a7
Update disney plus wrapper so all controls work. r=kpatenio

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0339d8c493a7