2013932 - nsDocShell::CreateInitialDocumentViewer should pass aCheckPermitUnload = false to viewer creation

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Vincent Hilla [:vhilla]]

See https://phabricator.services.mozilla.com/D281438#9750565.

When creating the initial viewer, there should be no viewer beforehand. We should consider

• Turning the assert for !mDocumentViewer in CreateInitialDocumentViewer into a diagnostic assert
• Asserting mInitialized in CreateAboutBlankDocumentViewer
• Passing false as aCheckPermitUnload argument to CreateAboutBlankDocumentViewer
• Maybe also asserting mInitialized && mDocumentViewer in DoURILoad.

I don't think we ever have a viewer already in CreateInitialDocumentViewer but it could happen in some edge case / race.

Comment 1

[Vincent Hilla [:vhilla]]

(In reply to Vincent Hilla [:vhilla] from comment #0)

See https://phabricator.services.mozilla.com/D281438#9750565.

• Maybe also asserting mInitialized && mDocumentViewer in DoURILoad.

Bug 2013289 tells us that we reach DoURILoad without viewer.

Comment 2

[Vincent Hilla [:vhilla]]

Attachment: Bug 2013932 - Be more strict about when docshell has a viewer and is initialized. r=#dom-core

Comment 3

[Vincent Hilla [:vhilla]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a5b4d19f9c14077db684d4d0107a2690cbefefca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0c8d0fd09335
https://hg.mozilla.org/integration/autoland/rev/ef5d383f2f1f
Be more strict about when docshell has a viewer and is initialized. r=dom-core,smaug

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ef5d383f2f1f