2014083 - Put custom review prompt back behind a feature flag

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Marcin Koziński]

Custom review prompt UI should be enabled only when a Nimbus feature flag is enabled. To simplify possible beta uplift add a new flag, say custom-review-prompt-ui and don't touch the existing flag (other than possibly updating docs and renaming for clarity).

Comment 1

[Marcin Koziński]

Attachment: Bug 2014083 - Create a new Nimbus flag for custom review prompt UI

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/56a37fb6f9fb
https://hg.mozilla.org/integration/autoland/rev/43d89a61b588
Create a new Nimbus flag for custom review prompt UI r=android-reviewers,twhite

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/43d89a61b588

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Without the flag, if custom review prompt hits issues again, we'll need to resort to uplifting to release to disable it.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Standard Nimbus flag configuration
• String changes made/needed: no
• Is Android affected?: yes

Comment 5

[Marcin Koziński]

Attachment: Bug 2014083 - Create a new Nimbus flag for custom review prompt UI

Original Revision: https://phabricator.services.mozilla.com/D281760

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/dc880224d368
https://hg.mozilla.org/releases/mozilla-beta/rev/32f2aab8249d