2014095 - @container style() feature parsing should allow !important modifier

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Kew [:jfkthame]]

It's not really clear to me from the spec at this point, but the WPT testcase at-container-style-parsing.html includes an example with !important that it expects to be accepted:

  test_cq_condition_known('style(--foo: bar !important)');

Currently (with the layout.css.style-queries.enabled pref enabled) our parsing rejects this as invalid.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 2014095 - Accept (and ignore) the !important flag when parsing a container style-feature query. r=#style

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/02afa137b8ca
https://hg.mozilla.org/integration/autoland/rev/454325963d29
Accept (and ignore) the !important flag when parsing a container style-feature query. r=firefox-style-system-reviewers,emilio

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/454325963d29

Comment 4

[Hamish Willee]

FF149 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/43216

All I have done is mentioned in the docs that !important is allowed, but more importantly, ignored. There is no need for a compatibility data entry because the feature is behind a pref still, and compatibility like this doesn't really matter until release. Ditto for release notes (we tend to record really significant additions only in release notes).