Closed Bug 2014181 Opened 9 months ago Closed 8 months ago

Fix matching of custom-property values in StyleFeature::matches

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame, NeedInfo)

References

Details

Attachments

(1 external file, 1 obsolete file)

When matching a @container style(...) query, it appears that StyleFeature::matches() fails to return true for custom property values where they would be expected to match.

Thus, given a container that defines --foo: bar, we're able to match style(--foo) (just checking that the custom property --foo is defined), but attempting to match style(--foo: bar) (to test the actual value) fails.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #9545290 - Attachment is obsolete: true
Attachment #9545289 - Attachment description: Bug 2014181 - patch 1 - Substitute custom props in universal-syntax values. r=#style → Bug 2014181 - Substitute custom property references in universal-syntax values. r=#style
Pushed by jkew@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/78dbe7c098be https://hg.mozilla.org/integration/autoland/rev/f20606140c53 Substitute custom property references in universal-syntax values. r=firefox-style-system-reviewers,emilio
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8b6e87ee12f6 https://hg.mozilla.org/integration/autoland/rev/7fe858f548cc Revert "Bug 2014181 - Substitute custom property references in universal-syntax values. r=firefox-style-system-reviewers,emilio" for causing wpt crashes on custom-property-style-queries.html.

Revert for causing wpt crashes on custom-property-style-queries.html.

Flags: needinfo?(jfkthame)
Pushed by jkew@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d76a2785e6b0 https://hg.mozilla.org/integration/autoland/rev/2dde77951553 Substitute custom property references in universal-syntax values. r=firefox-style-system-reviewers,emilio
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
Duplicate of this bug: 2017122
Duplicate of this bug: 2017657
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: