2014318 - Record pref telemetry in the metrics ping in addition to the events ping

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Vanessa asked that we send Suggest pref telemetry in the metrics ping in addition to the events ping as we currently do. There are a couple other non-Suggest urlbar prefs recorded in telemetry and I think we might as well add them to the metrics ping too.

I was wondering if we could start sending the value in the metrics ping in addition to the events ping. Our latest analysis indicate [not all users] send an urlbar event. In the query above Nadia isn't filtering on any event_category, but the events table is huge and writing any queries without event_category is very inefficient. It'd have been better to query from the metrics ping if the data were available.

I think having it available in the events ping is useful as well to cross reference with events data without ping joining, but given we want to start monitoring those metrics more closely moving forward it'd also be good to independently send on the metrics ping.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 2014318 - Record urlbar pref telemetry in the metrics ping in addition to the events ping.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9870882a7ac2
https://hg.mozilla.org/integration/autoland/rev/ad493911dd5c
Record urlbar pref telemetry in the metrics ping in addition to the events ping. r=daisuke,urlbar-reviewers

Comment 3

[Drew Willcoxon :adw]

STR for QA

This bug added all six urlbar pref_* metrics to the metrics ping. They were already recorded in the events ping and that hasn't changed, so now they're recorded in both. The six metrics start here: https://hg-edge.mozilla.org/integration/autoland/file/ad493911dd5c0e79f914065ed595594c89f9c62e/browser/components/urlbar/metrics.yaml#l794

The metrics will be listed in the pings as urlbar.pref_*, e.g., urlbar.pref_suggest_online_available.

I'm not sure you need to verify all six, one is probably fine. Each metric should be recorded on Firefox startup -- technically, when the first Firefox window opens.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 2014318 - Record urlbar pref telemetry in the metrics ping in addition to the events ping.

Original Revision: https://phabricator.services.mozilla.com/D281707

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: No user impact, but this is a nice-to-have that affects some telemetry that we use in experiments.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Please see the bug
• Risk associated with taking this patch: low
• Explanation of risk level: Simply adds some existing metrics to the metrics ping.
• String changes made/needed: none
• Is Android affected?: no

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ad493911dd5c

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/3f32c4a47be6
https://hg.mozilla.org/releases/mozilla-beta/rev/59d2a75a7522

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this fix on the latest Nightly 149.0a1 (Build ID: 20260205213633) on Windows 10, macOS 26.2 and Ubuntu 24.0.

• The following metrics are correctly registered and have the value of the prefs:
  • urlbar.pref_suggest_all
  • urlbar.pref_suggest_online_available
  • urlbar.pref_suggest_online_enabled
  • urlbar.pref_suggest_sponsored
  • urlbar.pref_suggest_topsites
  • urlbar.pref_max_results

I will also verify the issue also on Firefox 148 when the new Beta build is available.

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this fix on the latest Beta 148.0b12 (Build ID: 20260206090715) on Windows 10, macOS 26.2 and Ubuntu 24.0.

• The following metrics are correctly registered and have the value of the prefs:
  • urlbar.pref_suggest_all
  • urlbar.pref_suggest_online_available
  • urlbar.pref_suggest_online_enabled
  • urlbar.pref_suggest_sponsored
  • urlbar.pref_suggest_topsites
  • urlbar.pref_max_results