2014344 - `nsINode::IsSelected()` and `IsItemInRangeComparetor` should use `nsContentUtils::ComparePoints` and convert the points to the flattened tree if comparing within the flattened tree

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

Attachment: Bug 2014344 - Make `nsINode::IsSelected()` and `IsItemInRangeComparator` stop using `nsContentUtils::ComparePointsWithIndices()` r=jjaschke!,#dom-core

I'd like to hide nsContentUtils::ComparePointsWithIndices() because
it does not have information whether the offset is in TreeKind::DOM
or TreeKind::FlatForSelection.

This makes them convert the range boundaries to the corresponding
boundaries in the comparing tree.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3ee3e6da160a
https://hg.mozilla.org/integration/autoland/rev/7cfa190abe2f
Make `nsINode::IsSelected()` and `IsItemInRangeComparator` stop using `nsContentUtils::ComparePointsWithIndices()` r=jjaschke,dom-core

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7cfa190abe2f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c8c31f023b12
https://hg.mozilla.org/mozilla-central/rev/a3cb591e504c
Revert "Bug 2014344 - Make `nsINode::IsSelected()` and `IsItemInRangeComparator` stop using `nsContentUtils::ComparePointsWithIndices()` r=jjaschke,dom-core"

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/19-9/27)]

See bug 2014342 comment 5.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/943d10011843
https://hg.mozilla.org/integration/autoland/rev/b33026b9779e
Make `nsINode::IsSelected()` and `IsItemInRangeComparator` stop using `nsContentUtils::ComparePointsWithIndices()` r=jjaschke,dom-core-reviewers

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b33026b9779e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/68ce4a56be07
https://hg.mozilla.org/mozilla-central/rev/03269cd4884a
Revert "Bug 2014344 - Make `nsINode::IsSelected()` and `IsItemInRangeComparator` stop using `nsContentUtils::ComparePointsWithIndices()` r=jjaschke,dom-core-reviewers"

Comment 9

[Cristian Tuns]

Backed out for causing Bug 2052026

• Backout link

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e16f99c4eb2c
https://hg.mozilla.org/integration/autoland/rev/bacbdff11ccb
Make `nsINode::IsSelected()` and `IsItemInRangeComparator` stop using `nsContentUtils::ComparePointsWithIndices()` r=jjaschke,dom-core-reviewers

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bacbdff11ccb