2014493 - Re-use network error messages from m-c in felt

Status: RESOLVED FIXED

(Firefox Enterprise :: Client, task, P1)

Description

[Janika Neuberger [:janika]]

We already have localised network error messages (see https://searchfox.org/firefox-main/source/browser/locales/en-US/chrome/overrides/appstrings.properties) and a switch case that maps status to string id: https://searchfox.org/firefox-main/rev/ab8a90487516e59b3ac3b5cc503d024a2be8ea80/docshell/base/nsDocShell.cpp#3435-3753. We should outfactor that logic and re-use it when we have console connection errors and surface that in the felt window instead of duplicating and translating our own small set of network error messages.

Comment 1

[:gerard-majax]

(In reply to Janika Neuberger [:janika] from comment #0)

We already have localised network error messages (see https://searchfox.org/firefox-main/source/browser/locales/en-US/chrome/overrides/appstrings.properties) and a switch case that maps status to string id: https://searchfox.org/firefox-main/rev/ab8a90487516e59b3ac3b5cc503d024a2be8ea80/docshell/base/nsDocShell.cpp#3435-3753. We should outfactor that logic and re-use it when we have console connection errors and surface that in the felt window instead of duplicating and translating our own small set of network error messages.

Console connection error should use Fluent, not legacy properties, so I'm not sure there is much to factor from there

Comment 2

[Janika Neuberger [:janika]]

Conversation on this continues on GitHub: https://github.com/mozilla/enterprise-firefox/pull/358

Comment 3

[:gerard-majax]

(In reply to Janika Neuberger [:janika] from comment #2)

Conversation on this continues on GitHub: https://github.com/mozilla/enterprise-firefox/pull/358

Latest pushes uses Services.string so there is still some refactoring that could be done in mapping errors code that nsDocShell::DisplayLoadError does and we have to re-do, but at least strings are re-used on the PR now.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

See comment 3.