2014751 - attr() doesn't strike through attribute name when attribute value is not valid for the specified syntax in type()

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: test case

Steps to reproduce

1. Set layout.css.attr.enabled to true in about:config
2. Open the attached test case
3. Inspect the blue background Hello element

Expected results

In the rule view, for the background-color declaration, in attr() the data-bg is strike through (because the data-bg attribute value is 12px, which doesn't match the type(<color>) we have

Actual results

The blue fallback is strike through

---

This styling mechanism only check for the presence of the attribute, but when the attr() is using a type(), we should check that the value does check the syntax.
We can probably use InspectorUtils.valueMatchesSyntax (see InspectorUtils.webidl)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 2014751 - [devtools] Handle modern attr() syntax in OutputParser. r=#devtools.

Check if the attribute value does match the definedd attr() attr-type parameter
to see if the attribute value or the fallback is being used.
In the attr() tooltip, indicate when the attribute value doesn't match the specified
type.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7cfad5d34cab
https://hg.mozilla.org/integration/autoland/rev/3cf027900442
[devtools] Handle modern attr() syntax in OutputParser. r=devtools-reviewers,ochameau.

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3cf027900442