2014802 - Chat search opening (from search handoff tool) should always happen in the associated tab

Status: RESOLVED FIXED

(Core :: Machine Learning: General, defect, P1)

Description

[:Gijs (he/him)]

Chat.sys.mjs falls back to getTopWindow(), which could lead to opening the sidebar in a non-AI window. We shouldn't allow that, and instead require that we open in the same window.

Also, the selected tab might change between when the chat starts and when we invoke the tool, and we should make sure that the search opens in the same chat (and we should abort if the tab has since been closed, for instance).

Comment 1

[:Gijs (he/him)]

https://searchfox.org/firefox-main/rev/336fbf710daa1af13ff2bb550dd0ea1d4e82b305/browser/components/aiwindow/models/Chat.sys.mjs#178 has a context object with a win property, it basically wants to be a browsingContext object instead (and no fallback - if the browsingContext can't be found we should abort the search or handoff).

Comment 2

[Nick]

Attachment: Bug 2014802 - Chat search opening (from search handoff tool) should always happen in the associated tab r=omarg

Chat.sys.mjs falls back to getTopWindow(), which could lead to opening the sidebar in a non-AI window. We shouldn't allow that, and instead require that we open in the same window.

Also, the selected tab might change between when the chat starts and when we invoke the tool, and we should make sure that the search opens in the same chat (and we should abort if the tab has since been closed, for instance).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a775b5db6724
https://hg.mozilla.org/integration/autoland/rev/e7b4e76bb8ee
Chat search opening (from search handoff tool) should always happen in the associated tab r=Gijs,ai-frontend-reviewers,again

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e7b4e76bb8ee