2014811 - devtools-reps package has chrome:// URLs in CSS files

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Markus Stange [:mstange]]

https://github.com/firefox-devtools/profiler now depends on https://www.npmjs.com/package/devtools-reps , however there are some chrome:// URLs in the CSS, such as this one:

https://searchfox.org/firefox-main/rev/81cd862538be1cf95842a2ddfb7a5dd22c11ab25/devtools/client/shared/components/reps/reps.css#206

background: url("chrome://devtools/skin/images/arrow.svg") no-repeat center;

These URLs confuse some bundlers such as esbuild, and won't work in web content pages (especially not in other browsers).

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 2014811 - [devtools] Remove any reference to chrome URLs in reps npm package. r=#devtools

None of these styles are actually used in the profiler (nor in jsonviewer).
Let's do this stopgap solution until we better organize files within Reps.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc2d3d8b83db
https://hg.mozilla.org/integration/autoland/rev/a2631fe7cb07
[devtools] Remove any reference to chrome URLs in reps npm package. r=devtools-reviewers,nchevobbe

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a2631fe7cb07

Comment 4

[Markus Stange [:mstange]]

The version history at https://www.npmjs.com/package/devtools-reps?activeTab=versions now shows that 0.27.4 has been released twice, I think - once 3 months ago, and then again within the last 7 days. And https://www.npmjs.com/package/devtools-reps?activeTab=code still shows chrome URLs. (Edit: I misread the page, it wasn't released twice, the "last 7 days" is just about the number of downloads)

It looks like the fix hasn't been released yet, could you do a release?

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 2014811 - [devtools] Ship a new version of devtools-reps to npm. r=#devtools

Bump version to the released version number.
Document publishing with access token.
Allow publishing with changes outside of reps folder.

Comment 6

[Phabricator Automation]

Comment on attachment 9557915 [details]
Bug 2014811 - [devtools] Ship a new version of devtools-reps to npm. r=#devtools

Revision D289758 was moved to bug 2026115. Setting attachment 9557915 [details] to obsolete.

Comment 7

[Alexandre Poirot [:ochameau]]

(In reply to Markus Stange [:mstange] from comment #4)

It looks like the fix hasn't been released yet, could you do a release?

I'm releasing a new version in bug 2026115.