Closed
Bug 2015093
Opened 3 months ago
Closed 1 month ago
Add a moz-promo to welcome users to the redesign
Categories
(Firefox :: Settings UI, task)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
151 Branch
| Tracking | Status | |
|---|---|---|
| firefox151 | --- | fixed |
People
(Reporter: jules, Assigned: mkennedy)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp] )
Attachments
(2 files)
We decided to go with a simple moz-promo at the top of settings on the first pane (could we mirror to other panes? nice to have but not essential),
welcoming users back to the redesign and letting them dismiss it through a primary action.
| Reporter | ||
Updated•3 months ago
|
Whiteboard: [recomp]
Updated•3 months ago
|
Comment 1•2 months ago
|
||
We've agreed for this to go above the heading.
| Assignee | ||
Updated•2 months ago
|
Assignee: nobody → mkennedy
| Assignee | ||
Comment 2•1 month ago
|
||
| Assignee | ||
Comment 3•1 month ago
•
|
||
A few notes on things to verify for QA
- Set
browser.settings-redesign.enabledpref totrueto see the promo on each "new" setting pane (e.g. Home, AI Controls, etc), but it should not show on any of the legacy panes that are going away after the redesign flip (e.g. "General", etc). - If
browser.settings-redesign.enabledpref is unset or set tofalse, the promo should never show on any pane. - Clicking "Got it" on the promo should hide the promo across all panes and automatically set the
browser.settings-redesign.promo.dismissedpref totrue. - But the promo should show again on all relevant panes if
browser.settings-redesign.promo.dismissedpref is unset or set tofalse. - If
browser.settings-redesign.promo.dismissedis manually set totrue, the promo shouldn't show anywhere, even ifbrowser.settings-redesign.enabledpref is set totrue - Remember to reload setting page after pref changes. Changing a pref won't immediately reflect the promo change until after a reload.
| Assignee | ||
Comment 4•1 month ago
|
||
Attached image of what the promo looks like (browser was in dark-mode when I screenshotted, sorry lol). Figma link is linked in Jules' earlier comment.
Pushed by mkennedy@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/72a76ed8f7c7
https://hg.mozilla.org/integration/autoland/rev/09aaf0f4a626
Add new settings redesign promo r=fluent-reviewers,tgiles,bolsson,mstriemer,desktop-theme-reviewers
Comment 6•1 month ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox151:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Comment 7•1 month ago
|
||
| bugherder | ||
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c152/b151]
You need to log in
before you can comment on or make changes to this bug.
Description
•