2015114 - Remove code for KeyboardEvent.initKeyEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, task)

Description

[Mathew Hodson]

KeyboardEvent.initKeyEvent was unexposed to the Web by default in bug 1717760 and will be disabled for addons in bug 2015079.

Comment 1

[Mathew Hodson]

Attachment: Bug 2015114 - Remove code for KeyboardEvent.initKeyEvent r=masayuki

Also remove dom.keyboardevent.init_key_event.enabled_in_addons pref.

Comment 2

[Rob Wu [:robwu]]

Let's not land the removal too early. Copied from https://bugzilla.mozilla.org/show_bug.cgi?id=1842988#c6 :

The pref is false on release 147 by bug 1848384, which triggered a regression report at bug 2013772.

We are going to default to false to finalize the deprecation process in bug 2015079, but let's not rush to remove ASAP. Instead, let's monitor the fallout, and only finalize the removal if the impact is shown to be limited. Despite having deprecated years ago, users on release only started experiencing the effects from 147 on, and people used to old versions of an add-on working probably need some time to migrate to something else.

Comment 3

[Mathew Hodson]

Yeah I set the patch to WIP for that reason. I thought I would create this bug and still upload the patch because I had already started working on it before I noticed the regression in bug 2013772.

Comment 4

[Mathew Hodson]

Can you land this for me?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

done.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d3d87ed50ca4
https://hg.mozilla.org/integration/autoland/rev/b39af81e8644
Remove code for KeyboardEvent.initKeyEvent r=masayuki,webidl,frontend-codestyle-reviewers,smaug

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b39af81e8644