2015152 - settings redesign: DoH error page Change DNS settings button should focus on DNS over HTTPS section

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Valentin Gosu [:valentin]]

Set network.trr.mode:3 and go to kjahdfkjsadhfkasjhdf.com
Click on the Change DNS settings button

When browser.settings-redesign.enabled is false, the DNS over HTTPS section is revealed and highlighted.
When it is true, it just opens about:preferences#privacy

Comment 1

[Mark Striemer [:mstriemer]]

Looks like that button goes to the privacy-doh subcategory. Likely the group should get the subcategory: "doh" property set (searchfox)

ni? for awareness again

note: I'd run into some weirdness with the subcategory attribute but I don't recall what it was or if it was something else causing a problem. If that doesn't work right away reach out in #settings-desktop and we can investigate

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 2015152 - Change DNS settings button should redirect to DoH settings - r=emz!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/23abe7ef615c
https://hg.mozilla.org/integration/autoland/rev/78ca33f86c7f
Change DNS settings button should redirect to DoH settings - r=emz,akulyk

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/78ca33f86c7f